Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid 4 lines of --- when customization #133

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Avoid 4 lines of --- when customization #133

merged 2 commits into from
Aug 8, 2023

Conversation

NicolasCador
Copy link
Contributor

Questions Answers
Description? Avoid 4 lines of --- when customization
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Place an order with a product with customization, check alert email received for the new order and there aren't 4 lines of --- at the end of each product with customization

@NicolasCador
Copy link
Contributor Author

Before:
Before

After:
After

@mflasquin
Copy link
Contributor

Hi @NicolasCador can you fix the CI ? thanks

@NicolasCador
Copy link
Contributor Author

hi @mflasquin & @boherm,

ok, done

boherm
boherm approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@boherm boherm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI ✅
LGTM, thanks @NicolasCador!

@hibatallahAouadni hibatallahAouadni self-assigned this Aug 7, 2023
hibatallahAouadni
hibatallahAouadni approved these changes Aug 8, 2023
View reviewed changes
Copy link

@hibatallahAouadni hibatallahAouadni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @NicolasCador

Thanks for your PR 🚀
Indeed without your PR, we use to have these 4 lines of ---:

image

With your PR ✅

image

LGTM, QA ✅

Thanks!

@nicosomb nicosomb merged commit a8de66e into PrestaShop:dev Aug 8, 2023
8 checks passed
@nicosomb nicosomb added this to the 2.4.2 milestone Aug 8, 2023
@florine2623 florine2623 mentioned this pull request Sep 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hibatallahAouadni hibatallahAouadni hibatallahAouadni approved these changes

@boherm boherm boherm approved these changes

@nicosomb nicosomb nicosomb approved these changes

Assignees

@hibatallahAouadni hibatallahAouadni

Labels
QA ✔️
Projects
PR Dashboard
Archived in project
Milestone
2.4.2
Development

Successfully merging this pull request may close these issues.
5 participants
@NicolasCador @mflasquin @nicosomb @boherm @hibatallahAouadni