Remove usage of ajaxDie #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Hlavtox
commented
Feb 7, 2024
•
Hlavtox
commented
| Questions | Answers |
|---|---|
| Description? | ajaxDie is deprecated and ajaxRender should be used instead. Related to PrestaShop/PrestaShop#35283. |
| Type? | refactor |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | |
| Sponsor company | |
| How to test? |
Hlavtox
force-pushed
the
remove-ajaxdie
branch
from
ffcfa0e
to
d163527
Compare
ShaiMagal
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Verified that ajaxRender was introduced with 1.7.5. All good!
https://github.com/PrestaShop/PrestaShop/blob/1.7.4.4/classes/controller/Controller.php
https://github.com/PrestaShop/PrestaShop/blob/1.7.5.0-beta.1/classes/controller/Controller.php
|
Does not need any QA, the methods are the same. |
|
Hello @Hlavtox, Some checks were not successful, can you look at this? Thanks! |
paulnoelcholot
added
waiting for author
and removed
waiting for QA
ShaiMagal
approved these changes
Feb 7, 2024
|
@paulnoelcholot It's ready, just a random fail. :-) |
|
@PrestaShop/qa-functional Guys can I get a QA on this pls? |
|
Hello @Hlavtox, It's good for me! 🎉 Thanks! |
paulnoelcholot
approved these changes
Feb 20, 2024
paulnoelcholot
added
QA ✔️
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.