Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix grad norm fsdp #6

Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix grad norm fsdp #6

merged 1 commit into from
Jul 19, 2024

Conversation

samsja
Copy link
Collaborator

@samsja samsja commented Jul 18, 2024

@samsja samsja requested a review from Jackmin801 July 19, 2024 08:53
Copy link
Member

@Jackmin801 Jackmin801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense. LGTM!

@samsja samsja merged commit e4e4f86 into main Jul 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants