Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bnserr to hdf5 #198

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Bnserr to hdf5 #198

merged 2 commits into from
Feb 26, 2024

Conversation

smiet
Copy link
Collaborator

@smiet smiet commented Feb 1, 2024

The output of a freeboundary run should contain the bnserr.

Added bnserr as a global variable (was: local variable in xspec), and write it to the output group of the hdf5 file.

Updated version number of spec to 3.22 and of the python wrapper to 0.0.2 so user can check if this is available (f.ex. in simsopt).

Just asking for a sanity check, should not affect any existing use of SPEC.

Copy link
Collaborator

@jloizu jloizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jloizu
Copy link
Collaborator

jloizu commented Feb 1, 2024

I would say you can merge the pull request.

@smiet smiet merged commit f75a424 into master Feb 26, 2024
10 checks passed
@smiet smiet deleted the bnserr_to_hdf5_fix branch February 26, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants