Generate required files for examples/Tromp2005 from CMake #393
+249
−281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icui
changed the title
Rohit-Kakodkar
requested changes
Jan 16, 2025
| }, | ||
| "seismogram": { | ||
| "format": "ASCII", | ||
| "directory": "@CMAKE_SOURCE_DIR@/examples/Tromp_2005/OUTPUT_FILES/results", | ||
| "directory": "/Users/ccui/Documents/SPECFEMPP/examples/Tromp_2005/examples/Tromp_2005/OUTPUT_FILES/results", |
There was a problem hiding this comment.
Is this correct? Seems like your workdir got added here
| title: "Tromp-Tape-Liu (GJI 2005)" | ||
| description: | | ||
| Material systems : Elastic domain (1) | ||
| description: 'Material systems : Elastic domain (1) |
There was a problem hiding this comment.
Can you update the formatting so its easily readable? i.e. removing the next line after every entry within the same node. Look at cmakefiles/specfem_config.yaml.in within homogeneous example. I realize you probably just pasted this from the snakemake output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Closes #389