Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 278 - Refactor of domain folder. #413

Open
wants to merge 19 commits into
base: issue-228-anisotropy
Choose a base branch
from

Conversation

Rohit-Kakodkar
Copy link
Collaborator

Description

Sorry for the big PR 😣

This PR refactors the domain folder.

  • Promotes element_types from impl namespace to specfem::compute namespace
    • get_element_on_device functions are now part of element_types
  • Refactor kokkos_kernels so that the functions are using the macros
  • promote boundary conditions from specfem::domain::impl namespace to specfem::boundary_conditions
  • Delete domain folder and its namespace

Issue Number

closes #278

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

@lsawade
Copy link
Collaborator

lsawade commented Jan 17, 2025

Sorry for the big PR 😣

LOL this a big boi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants