This repository has been archived by the owner on Jan 24, 2018. It is now read-only.
Added afterFling listener #653
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables users to be able to execute logic after the smoothScroll animation has ended
| @@ -807,7 +810,8 @@ | |||
|
|
|||
| duration = duration * (1 - targetRatio); | |||
|
|
|||
| _instance.animateTo((targetTop + 0.5) | 0, {easing: 'outCubic', duration: duration}); | |||
| var direction = (distanceY)>0?'down':'up'; | |||
| _instance.animateTo((targetTop + 0.5) | 0, {easing: 'outCubic', duration: duration, done: _listeners.afterfling(direction)}); | |||
There was a problem hiding this comment.
Your code doesn't work, you're executing _listeners.afterfling(direction) immediately.
|
Apart from the issue I just commented on, I don't think this will work at all. When you touch the screen while an animation is running, then your listener will fire even though the user is still scrolling ( Line 739 in 1da1627 |
|
The issue you pointed out is indeed a bug and I'll resolve it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables users to be able to execute logic after the smoothScroll animation had ended