This repository has been archived by the owner on Jan 24, 2018. It is now read-only.
1.0.1: fixes for closure compiler #702
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "name": "skrollr", | |||
| "version": "0.6.31", | |||
There was a problem hiding this comment.
how is this related to this PR? The version is left out of bower on purpose as it can use tags.
There was a problem hiding this comment.
I wasn't aware that you could leave the version-nr out
|
I'm not really of fan of this. It basically removes some of the good parts of JS. I know that Google likes to make things look like Java (e.g. angular) but I don't. |
|
I agree that it removes some of the good parts of JS, but for me it's not a matter of taste but wanting to use the benefits of the closure compiler like DCE and code checking. From that perspective it also adds value to this library to at least have the option to use the closure compiler. Besides, most of the code is already compatible :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made some small changes to make skrollr compile with google closure compiler (advanced_optimizations).