-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hashing based Verification Token Handling #43
Conversation
This also fixes the bug in reverify email. @liam-sbhoo |
7eb9963
to
38f2546
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the inline comments
29bd2de
to
684d11e
Compare
Hi, Thanks |
621a767
to
5636876
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a minor change proposal. The only question I have left: what do we do if a user is not verified and forgot their password? Both in the case they have the access token for their account and if they do not.
Hi Sam, |
ok, i see. this sounds good :) |
5636876
to
2658e31
Compare
2658e31
to
f6ad536
Compare
Change Description
Try to be precise. You can additionally add comments to your PR, this might help the reviewer a lot.
It is an enhancement functionality where we ask user to input the verification token instead of verifying it with a link.
If you used new dependencies: Did you add them to
requirements.txt
?Who did you ping on Mattermost to review your PR? Please ping that person again whenever you are ready for another review.
@noahho
Breaking changes
If you made any breaking changes, please update the version number.
Breaking changes are totally fine, we just need to make sure to keep the users informed and the server in sync.
Does this PR break the API? If so, what is the corresponding server commit?
It did not break anything but a few users complained that our emails landed in spam. It is an update where we try to minimize the landing of emails in spam. Corresponding server PR: https://github.com/automl/tabpfn-server/pull/76
Does this PR break the user interface? If so, why?
No, it enhances the user interface.
Please do not mark comments/conversations as resolved unless you are the assigned reviewer. This helps maintain clarity during the review process.