-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setter of Access token #45
Conversation
3a593b1
to
4342114
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work!
I think we could add one more feature, where the user can set the token directly without having to go through the prompting. One example is, tabpfn.init(access_token='blablabla').
This is a misunderstaning in how the access token is sued. We only want to set the access token using a functional interface, so by calling tabpfn.set_token(...) not using the prompt interface. The token is useful if you want to programatically login, so I think we don't need any new code, but only add to the README doc how to login using the token |
c8f717c
to
68a0cb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some test cases? Also perhaps a demonstration on this work.
P.S: When you create a PR, would be nice to provide the reviewer an idea/demonstration of the new workflow.
557a0f5
to
3613acf
Compare
Hi Liam! As per your comments, I have updated the code and added test cases. |
I think this PR does not have much new stuff compared to the current main. I would close this, ok? Sorry about this |
Change Description
Try to be precise. You can additionally add comments to your PR, this might help the reviewer a lot.
Enhancement to set the access token if the user already has it.
If you used new dependencies: Did you add them to
requirements.txt
?Who did you ping on Mattermost to review your PR? Please ping that person again whenever you are ready for another review.
@liam-sbhoo
Breaking changes
If you made any breaking changes, please update the version number.
Breaking changes are totally fine, we just need to make sure to keep the users informed and the server in sync.
Does this PR break the API? If so, what is the corresponding server commit?
No
Does this PR break the user interface? If so, why?
No
Please do not mark comments/conversations as resolved unless you are the assigned reviewer. This helps maintain clarity during the review process.