generated from PrismarineJS/prismarine-template
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make dev builds faster #227
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AwesomestCode
approved these changes
Oct 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (nothing broke and it feels decently fast so I think that's good); if no one objects to merging I'll be merging it tomorrow.
rom1504
approved these changes
Oct 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok
Closed
rom1504
added a commit
that referenced
this pull request
Nov 12, 2021
extremeheat
referenced
this pull request
in extremeheat/prismarine-web-client
Apr 13, 2023
* Make SW generation prod-only * Use SpeedMeasurePlugin * Refactor: Symlink directories for dev builds * Lint fix * Remove SpeedMeasurePlugin
extremeheat
referenced
this pull request
in extremeheat/prismarine-web-client
Apr 13, 2023
This reverts commit 1e6d0f2. Fix #240
Moondarker
referenced
this pull request
in Moondarker/prismarine-web-client
Apr 13, 2023
* Make SW generation prod-only * Use SpeedMeasurePlugin * Refactor: Symlink directories for dev builds * Lint fix * Remove SpeedMeasurePlugin
Moondarker
referenced
this pull request
in Moondarker/prismarine-web-client
Apr 13, 2023
This reverts commit e98c116. Fix #240
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #210
What changed:
webpack.common.js
now exposesSymbol(webpack_directories)
andSymbol(webpack_files)
fields, instead of just copying everything (which is pretty slow)webpack.dev.js
uses ownSymlinkPlugin
to symlink directories listed inSymbol(webpack_directories)
webpack.prod.js
, since Workbox is disabled in development mode anyway