Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dev builds faster #227

Merged
merged 5 commits into from
Oct 26, 2021
Merged

Make dev builds faster #227

merged 5 commits into from
Oct 26, 2021

Conversation

Saiv46
Copy link
Contributor

@Saiv46 Saiv46 commented Oct 20, 2021

Closes #210

What changed:

  • webpack.common.js now exposes Symbol(webpack_directories) and Symbol(webpack_files) fields, instead of just copying everything (which is pretty slow)
  • webpack.dev.js uses own SymlinkPlugin to symlink directories listed in Symbol(webpack_directories)
  • GenerateSW plugin moved to webpack.prod.js, since Workbox is disabled in development mode anyway

Copy link
Member

@AwesomestCode AwesomestCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (nothing broke and it feels decently fast so I think that's good); if no one objects to merging I'll be merging it tomorrow.

Copy link
Member

@rom1504 rom1504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

@rom1504 rom1504 merged commit 8c88ec6 into PrismarineJS:master Oct 26, 2021
@Saiv46 Saiv46 deleted the patch-4 branch October 29, 2021 04:26
@rom1504 rom1504 mentioned this pull request Nov 7, 2021
rom1504 added a commit that referenced this pull request Nov 12, 2021
extremeheat referenced this pull request in extremeheat/prismarine-web-client Apr 13, 2023
* Make SW generation prod-only

* Use SpeedMeasurePlugin

* Refactor: Symlink directories for dev builds

* Lint fix

* Remove SpeedMeasurePlugin
extremeheat referenced this pull request in extremeheat/prismarine-web-client Apr 13, 2023
This reverts commit 1e6d0f2.

Fix #240
Moondarker referenced this pull request in Moondarker/prismarine-web-client Apr 13, 2023
* Make SW generation prod-only

* Use SpeedMeasurePlugin

* Refactor: Symlink directories for dev builds

* Lint fix

* Remove SpeedMeasurePlugin
Moondarker referenced this pull request in Moondarker/prismarine-web-client Apr 13, 2023
This reverts commit e98c116.

Fix #240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Webpack faster
3 participants