-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should show error screen on error #350
Conversation
Let me know what changes you will be interested in. I have changed the directory structure but I think I can still try to copy-paste some improvements & important bug fixes (such as incorrect creative bars update) ... or copy all changes along with reverting some of the commits |
please fix the ci |
I don't think changes in this PR caused ci failure. I had the same problem with Webpack (and Vite) locally. Seems they work badly when it comes to bundling large files (like these json files). CopyPlugin also may cause it I believe. I have solved these problems in one of the first commits, so have to remember. Anyway, I'll try to adjust the build process in this PR then. if you are interested in some other changes please let me know, I will try to rebase and group changes you interested in. Update: FYI not sure why (it doesn't happen on ci & in docker) but when I try to run npm i locally I get |
indeed CI is broken in main https://github.com/PrismarineJS/prismarine-web-client/actions/runs/5984401321/job/16235532976?pr=352 it needs to be fixed before we can merge anything |
Sorry, I lied, actually I just removed bedrock files from the build completely (because they have too large blocksj2b files). However, bedrock is supported here, right? Do you know how blocksj2b are used here or we can remove them? I'm not even sure how these files are used in prismarine projects at all yet. |
With this, it should show the error screen when an error actually happens (right now
setTimeout
seems to be removing it).Though in my fork I've rewritten the error screen so it's now possible to go back without having to reload the page. But I've also rewritten the screen history management, so I don't think I'll ever have time to cherry-pick so many commits, so I'm providing a simpler copy-paste solution for now.