Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to Python 3 #278

Merged
merged 60 commits into from
Jan 11, 2022
Merged

Port to Python 3 #278

merged 60 commits into from
Jan 11, 2022

Commits on Jan 3, 2022

  1. bump to the now-current nixpkgs release

    @exarkun
    exarkun committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    bede3e7 View commit details
    Browse the repository at this point in the history

  2. parameterize python version in the nix package

    @exarkun
    exarkun committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    96e4c46 View commit details
    Browse the repository at this point in the history

  3. fix problem with the new collections-extended dependency

    @exarkun
    exarkun committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    22b0a17 View commit details
    Browse the repository at this point in the history

  4. fix problem with the new cryptography build system

    @exarkun
    exarkun committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    d844ded View commit details
    Browse the repository at this point in the history

  5. fix the new conditional foolscap dependency

    @exarkun
    exarkun committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    5bfcb79 View commit details
    Browse the repository at this point in the history

  6. update the pypi database to get fresh-enough versions

    @exarkun
    exarkun committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    b3bacf4 View commit details
    Browse the repository at this point in the history

  7. add source for the now-current nixos release

    @exarkun
    exarkun committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    b7f22fc View commit details
    Browse the repository at this point in the history

  8. bump the shell environment nixos release as well

    @exarkun
    exarkun committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    013d873 View commit details
    Browse the repository at this point in the history

  9. respect the chosen python version in the tests and lint tools

    @exarkun
    exarkun committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    cd120f3 View commit details
    Browse the repository at this point in the history

  10. nope, use python39 for lint because tools are missing from py27 ecosy… 

    …stem
    @exarkun
    exarkun committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    0a0fe9d View commit details
    Browse the repository at this point in the history

  11. switch to flake8 to be able to suppress warnings 

    there will be tons of pyflakes warnings from the python3 porting strategy
    @exarkun
    exarkun committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    96137fe View commit details
    Browse the repository at this point in the history

  12. switch from the nixos release tag to branch 

    the branch has some python packaging fixes in nixpkgs that we need
    @exarkun
    exarkun committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    244cc32 View commit details
    Browse the repository at this point in the history

  13. fix nixpkgs pkgconfig so mach-nix works at all 

    also refactor tests.nix and default.nix so they share more of the environment
setup which is now slightly more complex
    @exarkun
    exarkun committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    86a8aa1 View commit details
    Browse the repository at this point in the history

  14. initial porting changes

    @exarkun
    exarkun committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    2bd1f45 View commit details
    Browse the repository at this point in the history

  15. black

    @exarkun
    exarkun committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    fc5684e View commit details
    Browse the repository at this point in the history

  16. isort

    @exarkun
    exarkun committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    ed8e0a0 View commit details
    Browse the repository at this point in the history

  17. add python3.9 to the ci testing matrix

    @exarkun
    exarkun committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    c123df9 View commit details
    Browse the repository at this point in the history

  18. fix all the noqa comments

    @exarkun
    exarkun committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    f296f9e View commit details
    Browse the repository at this point in the history

  19. more packaging fixes

    @exarkun
    exarkun committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    71658b3 View commit details
    Browse the repository at this point in the history

  20. changes for a passing test suite on 2.7 and 3.8

    @exarkun
    exarkun committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    4b5824b View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2022

  1. add a test for using the test vector feature 

    and fix it
    @exarkun
    exarkun committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    890e67d View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2022

  1. provide a shell where we can run tests, not just linters

    @exarkun
    exarkun committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    4dc239c View commit details
    Browse the repository at this point in the history

  2. strip explicit Python 2 support from the Nix packaging

    @exarkun
    exarkun committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    61dc80d View commit details
    Browse the repository at this point in the history

  3. Drop Python 2 from the CI matrix

    @exarkun
    exarkun committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    4c29995 View commit details
    Browse the repository at this point in the history

  4. commit to Python 3 for json.dumps

    @exarkun
    exarkun committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    bf7c312 View commit details
    Browse the repository at this point in the history

  5. drop __future__ and future imports 

    They're all redundant on Python 3
    @exarkun
    exarkun committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    36667f6 View commit details
    Browse the repository at this point in the history

  6. remove six and future dependency, also isort and black

    @exarkun
    exarkun committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    11a5df5 View commit details
    Browse the repository at this point in the history

  7. update packaging metadata

    @exarkun
    exarkun committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    0e489fa View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/main' into python3

    @exarkun
    exarkun committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    2c88272 View commit details
    Browse the repository at this point in the history

  9. drop py27 support from macos ci

    @exarkun
    exarkun committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    aab21d0 View commit details
    Browse the repository at this point in the history

  10. parameterize python version in nixos ci

    @exarkun
    exarkun committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    a990635 View commit details
    Browse the repository at this point in the history

  11. drop our copy of some eliot functions that we can now use from upstream

    @exarkun
    exarkun committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    11b4cc2 View commit details
    Browse the repository at this point in the history

  12. switch GitHub Actions to Python 3.9 as well

    @exarkun
    exarkun committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    ec1bf28 View commit details
    Browse the repository at this point in the history

  13. incompatible version formats ...

    @exarkun
    exarkun committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    ba62031 View commit details
    Browse the repository at this point in the history

  14. maybe this runs the configs I want

    @exarkun
    exarkun committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    adf0b03 View commit details
    Browse the repository at this point in the history

  15. nope, how about this

    @exarkun
    exarkun committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    a24eeee View commit details
    Browse the repository at this point in the history

  16. spurious mapping

    @exarkun
    exarkun committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    9ce11d0 View commit details
    Browse the repository at this point in the history

  17. normalize the CircleCI job names

    @exarkun
    exarkun committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    9936c1f View commit details
    Browse the repository at this point in the history

  18. Drop the workaround for the problem with older prometheus_client

    @exarkun
    exarkun committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    cc70a9c View commit details
    Browse the repository at this point in the history

  19. let setrlimit fail :/

    @exarkun
    exarkun committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    a8225b0 View commit details
    Browse the repository at this point in the history

  20. Add a test for get_root_nodes and fix the implementation

    @exarkun
    exarkun committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    6d098bc View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2022

  1. match the exact expected length

    @exarkun
    exarkun committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    1f134f9 View commit details
    Browse the repository at this point in the history

  2. more general reasoning about special cases for provider choices

    @exarkun
    exarkun committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    5d2670e View commit details
    Browse the repository at this point in the history

  3. replace typing comments with syntax

    @exarkun
    exarkun committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    46fa124 View commit details
    Browse the repository at this point in the history

  4. base64 encoded tokens are always ascii

    @exarkun
    exarkun committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    f6591cb View commit details
    Browse the repository at this point in the history

  5. required_passes is content with dict_values now

    @exarkun
    exarkun committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    92ba74c View commit details
    Browse the repository at this point in the history

  6. use f"" to simplify some string construction

    @exarkun
    exarkun committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    c621b05 View commit details
    Browse the repository at this point in the history

  7. cleanup stray keystroke

    @exarkun
    exarkun committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    ea07a48 View commit details
    Browse the repository at this point in the history

  8. Use FilePath instead of os.path

    @exarkun
    exarkun committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    f7f0c93 View commit details
    Browse the repository at this point in the history

  9. get rid of past.builtins.long usage

    @exarkun
    exarkun committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    14956bf View commit details
    Browse the repository at this point in the history

  10. drop the silly decode/encode dance for all the binding messages

    @exarkun
    exarkun committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    34e05c2 View commit details
    Browse the repository at this point in the history

  11. fixup comment in new test

    @exarkun
    exarkun committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    22b0014 View commit details
    Browse the repository at this point in the history

  12. Use auto_attribus on a couple exception types 

    However, we still cannot be frozen (because of Failure.cleanFailure) and
cannot use attrs exception support (because we want value-based comparison).
    @exarkun
    exarkun committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    1ebff29 View commit details
    Browse the repository at this point in the history

  13. Compare dict keys directly instead of via a set conversion 

    Co-authored-by: Tom Prince <[email protected]>
    @exarkun @tomprince
    exarkun and tomprince authored Jan 8, 2022
    Configuration menu
    Copy the full SHA
    67072ba View commit details
    Browse the repository at this point in the history

  14. It's already a text-mode FilePath, right? 

    TempDir.join(unicode) returns unicode
TempDir.join(bytes) raises an Exception
FilePath(unicode) produces a text-mode FilePath
StorageServer.__init__ raises an exception if passed bytes

So we can just rely on self.tempdir.path being the correct type already and
even if it weren't StorageServer would immediately tell us.
    @exarkun
    exarkun committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    39985b1 View commit details
    Browse the repository at this point in the history

  15. Pin Tahoe-LAFS exactly because we use an unofficial/unstable interface

    @exarkun
    exarkun committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    4ddd84c View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2022

  1. widen the required range to allow the Nix package

    @exarkun
    exarkun committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    4f59ff8 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. link to twisted tickets related to this

    @exarkun
    exarkun committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    209c83c View commit details
    Browse the repository at this point in the history

  2. Use __future__.annotations

    @exarkun
    exarkun committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    7581149 View commit details
    Browse the repository at this point in the history

  3. remove one more unnecessary asBytesMode call

    @exarkun
    exarkun committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    cb771a9 View commit details
    Browse the repository at this point in the history