Depend on Tahoe-LAFS 1.17.1 #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #282 +/- ##
==========================================
- Coverage 91.76% 91.76% -0.01%
==========================================
Files 51 51
Lines 4677 4689 +12
Branches 643 645 +2
==========================================
+ Hits 4292 4303 +11
- Misses 336 338 +2
+ Partials 49 48 -1
Continue to review full report at Codecov.
|
tomprince
suggested changes
Jan 11, 2022
src/_zkapauthorizer/_plugin.py
Outdated
| @@ -140,7 +140,8 @@ def get_storage_server( | |||
| registry=registry, | |||
| ) | |||
| storage_server = ZKAPAuthorizerStorageServer( | |||
| anonymous_storage_server, | |||
| # unwrap the Foolscap layer, we'll do it ourselves. | |||
| anonymous_storage_server._server, | |||
There was a problem hiding this comment.
Based on running the PrivateStorageio system tests, this is incorrect, as anonymous_storage_server is already a StorageServer, not a FoolscapStorageServer.
There was a problem hiding this comment.
Thanks for this catch. I'm surprised this is what Tahoe is doing now ... but since it is easier to deal with than what I expected, I guess I won't complain. 🙂
This suggests an integration test would be useful.
tomprince
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #278
Fixes #280