Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prohibit ; in identifiers (but allow ? in again) #389

Merged
merged 1 commit into from
May 20, 2022
Merged

Prohibit ; in identifiers (but allow ? in again) #389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/_zkapauthorizer/tests/strategies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1208,9 +1208,9 @@ def sql_identifiers() -> SearchStrategy[str]:
# Maybe ] should be allowed but I don't know how to quote it. '
# certainly should be but Python sqlite3 module has lots of
# problems with it.
# ? is disallowed due to how we substitute variables into
# SQL statements for the event-log
blacklist_characters=("\x00", "]", "'", "?"),
# ; is disallowed because sqlparse can't parse statements using it
# in an identifier.
blacklist_characters=("\x00", "]", "'", ";"),
),
)

Expand Down