Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Firebase #1

Open
wants to merge 3 commits into
base: privatestoragemobile-integration
Choose a base branch
from
Open

Remove Firebase #1

wants to merge 3 commits into from

Conversation

hacklschorsch
Copy link
Member

@hacklschorsch hacklschorsch commented Aug 3, 2023 •
edited
Loading

We don't use Firebase, and it is in the way of inclusion in F-Droid.
See https://whetstone.private.storage/privatestorage/privatestoragemobile/-/issues/92.

@hacklschorsch hacklschorsch changed the title Remove Firebase Draft: Remove Firebase Aug 3, 2023
@hacklschorsch
Copy link
Member Author

Marked as draft since while this by itself builds fine, privatestoragemobile doesn't build with it.

@hacklschorsch
Copy link
Member Author

Firebase must have transitively included androidx.core and its FileProvider class that we require.

Thanks @shapr for the help with getting the Haskell syntax right (by deleting more stuff!) and the idea to include above dep explicitly.

@hacklschorsch hacklschorsch changed the title Draft: Remove Firebase Remove Firebase Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hacklschorsch