Password Strength textual message added #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for skillwise ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@Srikar-1729 Your pull request has been successfully merged! Don't stop here—continue contributing by addressing more issues and aiming to become a top contributor. You can also contribute in my another Repository BuddyTrail which is also under Hacktoberfest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#541 feat (signup) : Added textual message to indicate the strength of the password to the already present password strength bar
Related Issue
Closes: #541
Description
1.Added text message indicating the strength of the password entered by the user during sign up process. This makes it easier to understand the purpose of the password strength bar already present and enhances UE.
2.Also previously there has been a slight issue regarding the password strength checking mechanism , it was implemented on the sign in page (where users who already have an account log in and it is not needed here) instead of the sign up page (where new users create their account for the first time and it is needed). I have corrected this as well.
Before :
Sign in (with the password strength checker which is not needed here)
Sign up
After:
Sign in
Sign up (with the password strength checker placed where it is actually needed)
Also the password strength message is now rendered.
Type of change
What sort of changes have you made:
Checklist