Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added skeleton screen loading for home page #856

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

AryanGupta001
Copy link
Contributor

@AryanGupta001 AryanGupta001 commented Oct 26, 2024

Title of the Pull Request

  • Have you renamed the PR Title in a meaningful way?

Related Issue

Closes: #850

Description

This PR introduces a skeleton loading screen for the homepage, improving the user experience by showing placeholder elements while the content is loading.

Type of change

What sort of changes have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the code style of this project.
  • I have followed the contribution guidelines
  • I have performed a self-review of my own code.
  • I have ensured my changes don't generate any new warnings or errors.
  • I have updated the documentation (if necessary).
  • I have resolved all merge conflicts.

Copy link

vercel bot commented Oct 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skillwise ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 8:58am

Copy link

netlify bot commented Oct 26, 2024

Deploy Preview for skillwise ready!

Name Link
🔨 Latest commit cabf83c
🔍 Latest deploy log https://app.netlify.com/sites/skillwise/deploys/67234695ce85350008a580a3
😎 Deploy Preview https://deploy-preview-856--skillwise.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PriyaGhosal
Copy link
Owner

@AryanGupta001
image
Please see the conflicts .

@PriyaGhosal
Copy link
Owner

@AryanGupta001 Are you working on it... as today is the last date of hacktoberfest 2024

@AryanGupta001
Copy link
Contributor Author

AryanGupta001 commented Oct 31, 2024

@AryanGupta001 Are you working on it... as today is the last date of hacktoberfest 2024

Yes. I will rectify and update the PR.

@AryanGupta001
Copy link
Contributor Author

I have corrected it.

@PriyaGhosal PriyaGhosal merged commit bd17e9b into PriyaGhosal:main Oct 31, 2024
6 checks passed
@PriyaGhosal
Copy link
Owner

@AryanGupta001 Great contribution ! 🎉 Your pull request has been successfully merged! Also Take a moment to ⭐ Star the repository if you haven't already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat : Add skeleton loading screen for home page
2 participants