Allow for specifying an arbitrary Team ID #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CRKatri
requested changes
Dec 13, 2023
ldid.cpp
Outdated
| @@ -2268,6 +2269,10 @@ Hash Sign(const void *idata, size_t isize, std::streambuf &output, const std::st | |||
| get(common, name, NID_commonName); | |||
| } | |||
|
|
|||
| if (flag_t != NULL) { | |||
| printf("ldid: Using team ID %s\n", flag_t); | |||
There was a problem hiding this comment.
Maybe don’t print this. No other flag prints stuff when it’s in use.
There was a problem hiding this comment.
Yep, looks like I forgot to remove this from testing
| @@ -3302,7 +3307,7 @@ static void usage(const char *argv0) { | |||
| fprintf(stderr, " host | kill | library-validation | restrict | runtime | linker-signed]] [-D] [-d]\n"); | |||
| fprintf(stderr, " [-Enum:file] [-e] [-H[sha1 | sha256]] [-h] [-Iname]\n"); | |||
| fprintf(stderr, " [-Kkey.p12 [-Upassword]] [-M] [-P[num]] [-Qrequirements.xml] [-q]\n"); | |||
| fprintf(stderr, " [-r | -Sfile.xml | -s] [-w] [-u] [-arch arch_type] file ...\n"); | |||
| fprintf(stderr, " [-r | -Sfile.xml | -s] [-w] [-u] [-tTeamID] [-arch arch_type] file ...\n"); | |||
There was a problem hiding this comment.
What format is TeamID supposed to be in? Add this flag and the format to the manpage.
|
I'm not really sure how to update docs/ldid.1, I've never used man pages before. The Team ID is just a 10-character string. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.