New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add requests timeout #131

Merged

rhymiz merged 1 commit into ProdPerfect:master from mschfh:requests-timeout

Oct 2, 2024

Contributor

mschfh commented Sep 9, 2024

The Python requests library does not set timeouts by default.
Without an explicit timeout, requests can potentially hang indefinitely.

This is also documented:

Nearly all production code should use this parameter in nearly all requests. Failure to do so can cause your program to hang indefinitely
https://requests.readthedocs.io/en/latest/user/quickstart/#timeouts


          Add requests timeout

0c98656

rhymiz approved these changes

View reviewed changes

rhymiz merged commit ef7a728 into ProdPerfect:master

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet