-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/duplicate board query #61
Open
albcl
wants to merge
50
commits into
ProdPerfect:master
Choose a base branch
from
albcl:feature/duplicate_board_query
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 35 commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
e9c2d80
Added "create board by workspace id"
albcl 748f418
Update readme
albcl 5480228
Added "duplicate board" query and type hint
albcl 5dc386d
Readme updated
albcl ed8e29d
Merge pull request #1 from albcl/feature/create_board_by_workspace_id
albcl 873dda3
Added extra parameters for the query
albcl f9e3a6e
Merge branch 'master' into feature/duplicate_board_query
albcl d707140
Query and tests updated
albcl 12b6834
Readme update
albcl f196586
Restructured Readme
albcl 89a5b8c
Added move_item_to_group and archive_item_by_id (#73)
tonymorello cdeaa30
Add id to payload of get_item_by_id_query (#74)
wbazant 050c32d
Feature/create board by workspace (#60)
albcl 02820ea
bump version
rhymiz 0d41eb5
Create CODE_OF_CONDUCT.md (#78)
rhymiz 0a9b87d
Update README.md
rhymiz 1a30751
docs: add rhymiz as a contributor for code (#79)
allcontributors[bot] 4340a28
docs: add tonymorello as a contributor for code (#80)
allcontributors[bot] cd885f8
docs: add chdastolfo as a contributor for code (#81)
allcontributors[bot] 1837e1d
docs: add lucioseki as a contributor for code (#84)
allcontributors[bot] ba4e159
docs: add yogeshnile as a contributor for code (#86)
allcontributors[bot] af5fa68
docs: add spencersamuel7 as a contributor for code (#88)
allcontributors[bot] bd9358d
Update .all-contributorsrc
rhymiz ee25c90
Update README.md
rhymiz 6d5b19b
Update README.md
rhymiz 53faa21
docs: add rhymiz as a contributor for code, bug, and maintenance (#90)
allcontributors[bot] 2153140
docs: add chdastolfo as a contributor for code, bug, and 2 more (#92)
allcontributors[bot] 4e2d9a0
docs: add pevner-p2 as a contributor for code (#93)
allcontributors[bot] 85154c8
1.3.3 (#96)
chdastolfo a528b00
docs: add t-a-y-l-o-r as a contributor for code (#97)
allcontributors[bot] fb9adc2
Readme updated
albcl 2b0689e
Update readme
albcl 1d38403
Readme update
albcl 93938a2
Restructured Readme
albcl 9cc8e82
Merge branch 'master' into feature/duplicate_board_query
albcl 17efb51
Tests improved
albcl 2335617
No need to declare variables again
albcl 3b2c1f0
Better type hints and default values
albcl 0b94fb1
Added missing query parameters
albcl d42b3ec
Added "duplicate board" query and type hint
albcl 8f445d5
Added extra parameters for the query
albcl 11ac7b5
Added "create board by workspace id"
albcl 5120dbc
Query and tests updated
albcl 5027df3
Fix __email__ typo
chdastolfo 0d9cf2f
Bump certifi from 2021.5.30 to 2022.12.7
dependabot[bot] 246bfc7
Convert README.md to .rst for readthedocs
chdastolfo 5226ae0
docs directory and sphinx setup
chdastolfo d32dd59
Merge branch 'ProdPerfect:master' into feature/duplicate_board_query
albcl f5cf788
Updated README
albcl 77c9ca3
fix/ missing query after rebasing
albcl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it should be indented once more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean to move it under the
workspace_id
condition? That condition is meant to only add to the params variable theworkspace_id
parameter for the query but it's not a mandatory condition for the query.However, there is a clear issue there because there isn't a value passed for the
%s
token, and the test didn't catch it because it was expecting to find a 1 and a 2 within the query, but both are included in theboard_id
value (Its value is 12) That was a really bad test.I have updated both the query and its test to fix these issues. I wonder if it had something to do with the merge when the branch was like +20 commits behind...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, now that I look at it again I'm not sure what I was talking about, it looks fine... disregard.
Good catch on test, and ty for fixing.