Fixes issue 756 geoJson namespace error #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-topway-it
changed the title
thomas-topway-it
changed the title
JeroenDeDauw
reviewed
Nov 2, 2023
| @@ -1,5 +1,9 @@ | |||
| <?php | |||
|
|
|||
| /** | |||
| * @reviewer thomas-topway-it for KM-A | |||
| */ | |||
There was a problem hiding this comment.
We do not add author or reviewer tags in this repo
There was a problem hiding this comment.
I will remove it
JeroenDeDauw
reviewed
Nov 2, 2023
| $parserOutput->setText( '' ); | ||
| return; | ||
| } | ||
| parent::fillParserOutput( $content, $cpoParams, $parserOutput ); |
There was a problem hiding this comment.
this is to set the correct parserOutput text by calling the same method in the parent class (JsonContentHandler)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #756
fixes 12 related errors running tests
the content of
fillParserOutputhas been fetched from Mediawiki 1.39.3JsonContentHandlerandSemanticGeoJsonStore -> storeGeoJsonargument contains the encoded raw json.The following block seems to cause the issue