-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #39 #53
Fix #39 #53
Conversation
hey, little bit busy right now, but I'll get on it in an hour or so. thanks for the pull request! btw, drop by the irc if you want (#reddit-progether on freenode). that's where most of the discussion is |
These commits break the bot, it doesn't run. As far as I can tell, it's mostly because the addons cannot locate ircBot from core anymore (since IRCBot is instantiated in main() instead of core now). I couldn't fix it myself and you would probably be able to fix it faster than I would. I won't be able merge this until it's fixed (and it's a pretty big bug). |
Also noticed that I didn't change how the settings worked in |
haha, I already was working on fixing that, it's added in, just testing it on heroku and pushing now |
merged |
Changes
irc.yaml
is now the configuration filesettings.txt
andsettings.py
used tomain.py
, and is passed to theIRCBot
at creation<-- not currently changedIRCBot
class is now instantiated inside ofmain.py
core.py
every time settings change/need to be read differenty)__init__
andrun
easier/more intuitively.idea
directory added to.gitignore
(it's a PyCharm project directory)settings.py
has been removed as it is now unnecessaryconfigparser.py
has been removed as it is now unnecessaryFixes