Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #39 #53

Closed
wants to merge 7 commits into from
Closed

Fix #39 #53

wants to merge 7 commits into from

Conversation

stoye
Copy link
Contributor

@stoye stoye commented Sep 27, 2014

Changes

  • irc.yaml is now the configuration file
    • it contains all information that settings.txt and settings.py used to
    • PyYAML module is used to parse this file at startup in main.py, and is passed to the IRCBot at creation
  • IRCBot class is now instantiated inside of main.py <-- not currently changed
    • allows abstraction of settings file (won't have to change core.py every time settings change/need to be read differenty)
    • allows steps to happen between __init__ and run easier/more intuitively
  • .idea directory added to .gitignore (it's a PyCharm project directory)
  • settings.py has been removed as it is now unnecessary
  • configparser.py has been removed as it is now unnecessary

Fixes

@stoye stoye changed the title Fix 39 Fix #39 Sep 27, 2014
@projectdelphai
Copy link
Member

hey, little bit busy right now, but I'll get on it in an hour or so. thanks for the pull request!

btw, drop by the irc if you want (#reddit-progether on freenode). that's where most of the discussion is

@projectdelphai
Copy link
Member

These commits break the bot, it doesn't run. As far as I can tell, it's mostly because the addons cannot locate ircBot from core anymore (since IRCBot is instantiated in main() instead of core now). I couldn't fix it myself and you would probably be able to fix it faster than I would. I won't be able merge this until it's fixed (and it's a pretty big bug).

@stoye
Copy link
Contributor Author

stoye commented Sep 27, 2014

Also noticed that I didn't change how the settings worked in db.py, so I fixed that as well. Everything should work as intended now.

@projectdelphai
Copy link
Member

haha, I already was working on fixing that, it's added in, just testing it on heroku and pushing now

@projectdelphai
Copy link
Member

merged

@stoye stoye deleted the fix-39 branch September 27, 2014 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants