No recuperar soluciones para creador #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asanzo
reviewed
Sep 25, 2023
| @@ -99,6 +105,8 @@ export default Service.extend({ | |||
| }, | |||
|
|
|||
| async _send(method, resource, body, critical = true) { | |||
| if(resource.includes('solution') && this.isCreatorURL()) return //Should not send or get solution when using the creator | |||
There was a problem hiding this comment.
Medio raro un if en el send, me lo hubiera esperado en el momento de enviar la solución, arriba en executionFinished
There was a problem hiding this comment.
Lo puse ahí para no repetir el if en tres lugares, tendría que estar en lastSolution y runProgram también, pero se puede dejar en esos lugares si no.
asanzo
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1439
No pude levantarlo con el backend de verdad (después le gasto un tiempito a ver qué pasa que no me levanta), pero con el trucazo de copiarme el PB_USER al storage no pareciera estar tomando la solution.
También intenté hacer tests pero no logré mockear la url de forma que no rompa todo (xd), para no extenderlo no lo seguí pero también puedo gastarle un tiempillo si lo consideran necesario.
Cuando este aprobado hago el release para react:)