Error en solución del creador #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlopezalvas
changed the title
dlopezalvas
commented
Nov 24, 2023
| @@ -104,7 +104,7 @@ export default Component.extend({ | |||
| }, | |||
|
|
|||
| guardarSolucion() { | |||
| let activityName = this.get("actividad.nombre") || this.storage.getImportedChallenge()?.titulo || "Sin título" | |||
| let activityName = this.get("actividad.nombre") || "SinTitulo" | |||
There was a problem hiding this comment.
En teoría nunca debería venir sin un nombre ahora, asi que podría tampoco estar el SinTitulo 👀
There was a problem hiding this comment.
no estaria de mas...
danielferro69
approved these changes
Nov 28, 2023
| @@ -104,7 +104,7 @@ export default Component.extend({ | |||
| }, | |||
|
|
|||
| guardarSolucion() { | |||
| let activityName = this.get("actividad.nombre") || this.storage.getImportedChallenge()?.titulo || "Sin título" | |||
| let activityName = this.get("actividad.nombre") || "SinTitulo" | |||
There was a problem hiding this comment.
no estaria de mas...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1521
pilas-bloques-react: Program-AR/pilas-bloques-app#145