Fix the use of allow_smaller in CropForeground
#6686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
wyli
reviewed
Jul 2, 2023
Co-authored-by: Wenqi Li <[email protected]> Signed-off-by: YunLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
wyli
approved these changes
Jul 3, 2023
Signed-off-by: KumoLiu <[email protected]>
|
/build |
KumoLiu
added a commit
to KumoLiu/MONAI
that referenced
this pull request
Jul 18, 2023
Signed-off-by: KumoLiu <[email protected]>
wyli
pushed a commit
that referenced
this pull request
Jul 18, 2023
Fixes #6685. - Revert #6686 without changing the meaning of `allow_smaller` in `generate_spatial_bounding_box`. - Update the docstring of the `allow_smaller` to make it more clear. - Add `deprecated_arg_default`, then after 1.3, `CropForeground` with pad by default even if the image edges are smaller than the final box edges. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: KumoLiu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6685 .
Description
When
allow_smaller=True, it allows the image size to be smaller than the box size and will pad it.But in
generate_spatial_bounding_box, it generates the wrong bounding box.MONAI/monai/transforms/utils.py
Lines 1001 to 1003 in e7fb74f
Change the default value of
allow_smallerinCropForegroundtoFalseto be consistent with the previous behavior.Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.