feat: add channel_wise option for ShiftIntensity
#6789
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saurav Maheshkar <[email protected]>
Signed-off-by: Saurav Maheshkar <[email protected]>
wyli
reviewed
Jul 27, 2023
| """ | ||
|
|
||
| backend = [TransformBackends.TORCH, TransformBackends.NUMPY] | ||
|
|
||
| def __init__(self, offset: float, safe: bool = False) -> None: | ||
| def __init__(self, offset: float, safe: bool = False, channel_wise: bool = False) -> None: |
There was a problem hiding this comment.
Thank you, please also update the corresponding APIs in https://github.com/Project-MONAI/MONAI/blob/dev/monai/transforms/intensity/dictionary.py and add test cases to the existing unit tests such as https://github.com/Project-MONAI/MONAI/blob/dev/tests/test_shift_intensity.py
KumoLiu
reviewed
Jul 28, 2023
| return out | ||
| if self.channel_wise: | ||
| for i, d in enumerate(img): | ||
| out = d + offset |
There was a problem hiding this comment.
Thanks, but if you don't randomize offset here, the output won't make any difference since offset is a constant.
There was a problem hiding this comment.
Ahh yes good catch, any suggestions on how I do this ?
There was a problem hiding this comment.
Hi @SauravMaheshkar, I would suggest you refer to this PR.
Thanks!
|
Hi @SauravMaheshkar, do we have any update on this PR? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6629
Description
This PR aims to add the option to perform the
ShiftIntensityoperation in achannel_wisemanner.Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.