Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6799 do not compare types #6801

Merged
merged 2 commits into from
Jul 31, 2023
Merged

6799 do not compare types #6801

merged 2 commits into from
Jul 31, 2023

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Jul 31, 2023

Fixes #6799.

Do not compare types, for exact checks use is / is not, for instance checks use isinstance().

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

KumoLiu and others added 2 commits July 31, 2023 16:11
@wyli
Copy link
Contributor

wyli commented Jul 31, 2023

/build

@wyli wyli enabled auto-merge (squash) July 31, 2023 09:42
@wyli wyli merged commit c4ff70b into Project-MONAI:dev Jul 31, 2023
28 of 32 checks passed
@KumoLiu KumoLiu deleted the compare-type branch August 1, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E721 do not compare types
2 participants