-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image space and World Space convert transforms #7942
Conversation
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
…orld2image Signed-off-by: YunLiu <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: YunLiu <[email protected]>
Hey @KumoLiu, I am going over the code. Can you please share the data |
Signed-off-by: YunLiu <[email protected]>
Sure, I have uploaded the Google Drive link. I annotated it by using 3d slicer. |
My apologies, I had to write slides for a presentation today and I've had no time to review this yet. |
Signed-off-by: YunLiu <[email protected]>
Thanks @KumoLiu I am going over it. |
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Hello Yun,
Again, I must say, I do not think that there will be a problem, but just to make sure it works in the aforementioned cases. |
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for testing the coronal and sagittal pieces @KumoLiu.
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
/build |
Signed-off-by: YunLiu <[email protected]>
Hi @vikashg @atbenmurray @aylward @mingxin-zheng @Nic-Ma, do you have any further comments? Otherwise I will try to merge this one. Thanks. |
Hey Yun, Thanks |
Hey @KumoLiu, Also, please add |
Co-authored-by: Mingxin Zheng <[email protected]> Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Hi @mingxin-zheng @vikashg, add the use case description in the docstring. please help take a look whether it makes clearer to you, thanks! MONAI/monai/transforms/utility/array.py Line 1748 in 48707ed
|
Thanks and it looks good to me! |
Hi @vikashg, I take a look at your gist. The issue is that you need transform the point in the world space but you are transform the data already in the image space.
|
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
/build |
Thanks @KumoLiu. That solves it. |
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @KumoLiu Really appreciate all the hard work you have put on this. Looks great to me.
/build |
Fixes # . ### Description Add `ImageToWorldSpace` and `WorldToImageSpace` ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: YunLiu <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Eric Kerfoot <[email protected]> Co-authored-by: Mingxin Zheng <[email protected]>
Fixes # .
Description
Add
ImageToWorldSpace
andWorldToImageSpace
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.