-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print what package should be installed when suitable writer is missing #8001
base: dev
Are you sure you want to change the base?
Conversation
Fixes Project-MONAI#7980 Signed-off-by: ytl0623 <[email protected]>
for more information, see https://pre-commit.ci
"nii": ["nibabel"], | ||
"nii.gz": ["nibabel"], | ||
"dcm": ["pydicom"], | ||
# Add more mappings as needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who is supposed to add the rest of the entries on this list? ITK supports quite a few, including all of the ones you listed above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add ITK for a number of these types though the listed libraries are the primary ones used. If you can identify what other libraries load each of these types (and other types that can be loaded) please add them here as well.
Hi @ytl0623, thanks for the pr! Given that we already have a
|
Hi @ytl0623, Do you plan to address the comments on the PR? If not, I’d be happy to assist with it. I’m hoping we can get this merged into version 1.4, but we only have about one or two weeks left to add new features. |
Hi @KumoLiu, I apologize for the delay in responding. I’m willing to assist it. It might take me a little time, but I’ll make sure to work on it and keep you updated. |
@KumoLiu, hello, I want to help with merging this PR. How can I do so? Make a new PR with changes you requested? |
@KumoLiu, do we want to keep modifications in module.py? |
No, we can just extend the existing |
Fixes #7980
Description
To implement these changes:
from typing import Dict, List
import.WRITER_PACKAGE_MAP
dictionary after the existing imports.OptionalImportError
class with the new version provided above.For example, if you try to save a PNG file without Pillow installed, you'll now get an error message like:
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.