Add Average Precision to metrics #8089
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thibaultdvx <[email protected]>
Signed-off-by: thibaultdvx <[email protected]>
Signed-off-by: thibaultdvx <[email protected]>
Signed-off-by: thibaultdvx <[email protected]>
Signed-off-by: thibaultdvx <[email protected]>
Signed-off-by: thibaultdvx <[email protected]>
Signed-off-by: thibaultdvx <[email protected]>
Signed-off-by: thibaultdvx <[email protected]>
for more information, see https://pre-commit.ci
|
/build |
|
hi @KumoLiu, could you please have a look at this PR? |
KumoLiu
reviewed
Oct 22, 2024
Comment on lines
+83
to
+84
| `Average Precision` | ||
| -------------------------- |
There was a problem hiding this comment.
Suggested change
| `Average Precision` | |
| -------------------------- | |
| `Average Precision` | |
| ------------------- |
ericspod
reviewed
Oct 22, 2024
|
|
||
| class AveragePrecisionMetric(CumulativeIterationMetric): | ||
| """ | ||
| Computes Average Precision (AP). Referring to: `sklearn.metrics.average_precision_score |
There was a problem hiding this comment.
For the lazy it would be nice to explain here what this metric is and its intended application area.
ericspod
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8085.
Description
Average Precision is very similar to ROCAUC, so I was very much inspired by the ROCAUC implementation.
More precisely, I created:
AveragePrecisionMetricandcompute_average_precisioninmonai.metrics,AveragePrecisioninmonai.handlers,test_compute_average_precision.py,test_handler_average_precision.pyandtest_handler_average_precision_dist.py.I also modified the docs to mention Average Precision.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.