Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ImageFilter to allow Gaussian filter without filter_size #8189

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Fix ImageFilter to allow Gaussian filter without filter_size #8189

wants to merge 5 commits into from
+8 −2

Commits on Nov 6, 2024

  1. Fix ImageFilter to allow Gaussian filter without filter_size 

    Fixes Project-MONAI#8127

Update `ImageFilter` to handle Gaussian filter without requiring `filter_size`.

* Modify `monai/transforms/utility/array.py` to allow Gaussian filter without `filter_size`.
  - Adjust `_check_filter_format` method to skip `filter_size` check for Gaussian filter. Indeed Gauss filter is the only one in the list that doesn't require a filter_size.
* Add unit test in `tests/test_image_filter.py` for Gaussian filter without `filter_size`.
  - Verify output shape matches input shape.

Note that this method is compliant with the dictionnary version since this one load the fixed version.

Signed-off-by: Eloi Navet <[email protected]>
    @EloiNavet
    EloiNavet committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    137892a View commit details
    Browse the repository at this point in the history

  2. Update array.py 

    To satisfy the linter

Signed-off-by: Eloi <[email protected]>
Signed-off-by: Eloi Navet <[email protected]>
    @EloiNavet
    EloiNavet committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    e4dc6a8 View commit details
    Browse the repository at this point in the history

  3. DCO Remediation Commit for Eloi <[email protected]> 

    I, Eloi <[email protected]>, hereby add my Signed-off-by to this commit: 79e8aa0

Signed-off-by: Eloi <[email protected]>
Signed-off-by: Eloi Navet <[email protected]>
    @EloiNavet
    EloiNavet committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    7c5b8a0 View commit details
    Browse the repository at this point in the history

  4. DCO Remediation Commit for Eloi <[email protected]> 

    I, Eloi [email protected], hereby add my Signed-off-by to this commit: 79e8aa0

Signed-off-by: Eloi [email protected]
Signed-off-by: Eloi Navet <[email protected]>
    @EloiNavet
    EloiNavet committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    df0a97c View commit details
    Browse the repository at this point in the history

  5. DCO Remediation Commit for Eloi Navet <[email protected]> 

    I, Eloi Navet <[email protected]>, hereby add my Signed-off-by to this commit: 82715cb

Signed-off-by: Eloi Navet <[email protected]>
    @EloiNavet
    EloiNavet committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    fb5be1c View commit details
    Browse the repository at this point in the history