MONAI support #33
Open
MONAI support #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #33 +/- ##
==========================================
- Coverage 66.81% 65.21% -1.60%
==========================================
Files 8 8
Lines 2091 2139 +48
Branches 338 361 +23
==========================================
- Hits 1397 1395 -2
- Misses 598 640 +42
- Partials 96 104 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for use of the metrics in
pairwise_measures.pyto be used from MONAI, in particular it enables the use of a batch dimension and a smoothing parameter. Some small modifications have also been made in some places to make the code slightly more efficient (e.g, one-hot encode only once inMultiClassPairwiseMeasures.weighted_cohens_kappa, repeated computations removed fromMultiClassPairwiseMeasures.normalised_expected_cost., etc). All unit tests pass, and the smoothing parameters is disabled by default; that is, the output of the metrics have not changed. With this PR integrated into the package, the wrapper on the MONAI side (for the pairwise metrics) should be easy to implement :)