Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to release v2.0 that is dependent on HSDK v2 #485

Merged
merged 5 commits into from
Apr 24, 2024
Merged

Update to release v2.0 that is dependent on HSDK v2 #485

merged 5 commits into from
Apr 24, 2024

Conversation

MMelQin
Copy link
Collaborator

@MMelQin MMelQin commented Apr 22, 2024 •
edited
Loading

Changes needed to prepare for v2.0 release (on the newly release Holoscan SDK v2.0):

  • Updated the SDK to use Holoscan SDK V2.x, holoscan~=2.0
  • Fixed a field issue where DICOMDir was erroneously exported from the PACS and ingested by the MIG, and not filtered out by the MD App SDK. The fix is to add a exclusion/ignore list of unwanted SOP Classes by the UID, e.g. DICOMDir SOP Class

@MMelQin MMelQin changed the title WIP: Update to use HSDK v2 Update to release v2.0 that is dependent on HSDK v2 Apr 24, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@MMelQin MMelQin merged commit ca30b03 into main Apr 24, 2024
3 checks passed
@MMelQin MMelQin linked an issue Apr 24, 2024 that may be closed by this pull request
[BUG] DICOM Loader should ignore DICOMDIR insance #486
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mocsharp mocsharp mocsharp approved these changes

@gigony gigony Awaiting requested review from gigony

@vikashg vikashg Awaiting requested review from vikashg

@dbericat dbericat Awaiting requested review from dbericat

@GreySeaWolf GreySeaWolf Awaiting requested review from GreySeaWolf

@rahul-imaging rahul-imaging Awaiting requested review from rahul-imaging

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] DICOM Loader should ignore DICOMDIR insance
2 participants
@MMelQin @mocsharp