lowered logging level thats flooding logs #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil South <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #54 +/- ##
=============================================
Coverage 97.47191% 97.47191%
=============================================
Files 12 12
Lines 356 356
Branches 37 37
=============================================
Hits 347 347
Misses 7 7
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Neil South <[email protected]>
|
@dependabot recreate |
mocsharp
reviewed
Jan 5, 2024
| @@ -20,7 +20,7 @@ namespace Monai.Deploy.WorkflowManager.Logging | |||
| { | |||
| public static partial class Log | |||
| { | |||
| [LoggerMessage(EventId = 500000, Level = LogLevel.Information, Message = "Bypass authentication.")] | |||
| [LoggerMessage(EventId = 500000, Level = LogLevel.None, Message = "Bypass authentication.")] | |||
There was a problem hiding this comment.
Do we want to set this to debug instead of none?
mocsharp
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # .
A few sentences describing the changes proposed in this pull request.
Status
Ready/Work in progress/Hold
Types of changes