Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance readme for ddp cases in ldm tutorials #1857

Merged
merged 8 commits into from
Oct 9, 2024

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Oct 9, 2024

Enhance readme for ddp cases in ldm tutorials
Add amp argument in maisi diffusion training notebook as a workaround for #1858.

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dongyang0122
Copy link
Collaborator

Thank you. All changes look good to me.

@KumoLiu KumoLiu merged commit fa73d25 into Project-MONAI:main Oct 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants