Fix manuever overrides finding bug

[rezashokry]

Issue

I was trying to add some maneuver override relation to the map and I noticed some of them are not working.
I tried to find out why and I figured out this is because there is a vector of maneuver overrides which is assumed to be sorted to use binary search on it in lookup but its not sorted at the binary search stage.
The vector is already sorted in extract function but after the renumber in partition function the vector becomes unsorted.

Extraction:
https://github.com/Project-OSRM/osrm-backend/blob/master/src/extractor/edge_based_graph_factory.cpp#L1225

Renumbering in partitioner: (which doesn't maintain the sorted array)
https://github.com/Project-OSRM/osrm-backend/blob/master/src/partitioner/partitioner.cpp#L163C1-L163C1

Finding maneuver overrides for each node:
https://github.com/Project-OSRM/osrm-backend/blob/master/src/engine/guidance/post_processing.cpp#L582

Binary search on the vector:
https://github.com/Project-OSRM/osrm-backend/blob/master/include/engine/datafacade/contiguous_internalmem_datafacade.hpp#L600

I just simply sort the vector after the rename function before the partition function writes it down.

Tasklist

• CHANGELOG.md entry (How to write a changelog entry)
• update relevant Wiki pages
• add tests (see testing documentation)
• review
• adjust for comments
• cherry pick to release branch

Requirements / Relations

This pull request fixes this issue.

[mjjbell]

Good spot. Looks like it happened in #4907
I'll create a test case from your original example to confirm the fix.

[mjjbell]

As this is a bug related to the multi-level partitioning, it's difficult to add a neat Cucumber test case.

However, I've verified the fix using the example PBFs from the issue details - thanks for providing them, it's very helpful.

[mjjbell]

@rezashokry can you add an entry to CHANGELOG.md ?