Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uncomment "cyclability" weight name #7043

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

szymon-szym
Copy link

@szymon-szym szymon-szym commented Sep 29, 2024

Issue

It looks like in profile/bicycle.lua the weight_name in properties was unintentionally commented out

Without it set to cyclability the safety_check is committed when using this profile. Turns' weights are also calculated differently

Tasklist

Requirements / Relations

@frodrigo
Copy link
Member

frodrigo commented Oct 1, 2024

From the introduction of the concept weight in bicycle profile, it always be duration as default.

279f8aabfb#diff-c4b120b8978b0193746a4accb230bf085b89bca0fdda9f17920e056ddaee820fR58

I see this PR as a possible breaking change.

Nevertheless can can still use cyclability on you side if you prefer it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants