-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Autokick of ghost characters #720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR is from a Lead Developer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it a bit more and I have three improvement proposals to make this more usable:
- It currently also kicks ghost in room devices. This is may be undesired sometimes and also leads to the need for another manual step due to the issue that I described in Clear kicked/banned players from device slots automatically #714
I propose to add another toggle "Also affect characters in the slots of room-level items" with a default off.
-
I think public and private spaces are a bit different, so another toggle "Also in effect when the space is private" with a default off.
-
Less of a priority, but nice to have: When you currently enter a value of "0", I would expect that it kicks instantly when the disconnect message is printed in the chat (ideally without a separate chat message to not be spammy). Currently, a value of "0" still means after 1 minute. This is very minor and likely too much effort to address right now, but I thought it may be a nice idea. (or we simply do not allow to enter any values below 1)
4759414
to
15afea1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!~
Adds ability to configure automatic kick of offline characters.
The scan for offline characters happens regularly by Shard and checks if character has been offline for X minutes before requesting Directory to kick it. If the request fails for whatever reason, it will be re-attempted during the next cycle.
Also has an option to ignore Owners/Admins/VIPs of a space.
Additionally increased the randomness of initial position generation 5-fold.