Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add intenationalization to Frontend #117

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add intenationalization to Frontend #117

wants to merge 3 commits into from

Conversation

ggfto
Copy link
Contributor

@ggfto ggfto commented Apr 16, 2024

Implementation of internationalization to the Frontend

  • New languages can be added with a corresponding JSON;
  • The JSON name will be the same as the .lua files for language;
  • Kept English as primary.

@MonkeyWhisper
Copy link
Member

Thanks for the review, I need to test this, quit a lot of changes here

@MonkeyWhisper MonkeyWhisper added the help wanted Extra attention is needed label Jul 6, 2024
@ggfto ggfto closed this Jul 9, 2024
@ggfto ggfto deleted the translations-frontend branch July 9, 2024 00:02
@ggfto ggfto restored the translations-frontend branch July 9, 2024 00:02
@ggfto ggfto reopened this Jul 15, 2024
@ggfto
Copy link
Contributor Author

ggfto commented Jul 15, 2024

deleted the branch by mistake

@lenzh
Copy link
Contributor

lenzh commented Jul 25, 2024

code seems solid, only thing is add a en locale file as default

@ggfto
Copy link
Contributor Author

ggfto commented Jul 27, 2024

code seems solid, only thing is add a en locale file as default

even with the english within the i18n.ts file we need a en locale for reference?

@ggfto
Copy link
Contributor Author

ggfto commented Aug 4, 2024

@lenzh I've added the en.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggfto @MonkeyWhisper @lenzh