Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore/Issue 1016: Replace the use of request with fetch in test cases #1172

Merged
merged 10 commits into from
Nov 8, 2023
Merged

chore/Issue 1016: Replace the use of request with fetch in test cases #1172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d819a76
Issue 1016: Initital attempt at using fetch over request
DevLab2425 Oct 18, 2023
23f9a39
Issue-1016: Refactor IP to use localhost url
DevLab2425 Oct 19, 2023
4b5bcfe
Issue-1016: Initial POST refactor to fetch
DevLab2425 Oct 19, 2023
b1d197f
Issue-1016: Progress on removal of request
DevLab2425 Oct 19, 2023
071c54d
Issue-1016: Additional removal of request
DevLab2425 Oct 19, 2023
cf4a6d6
Issue-1016: Finalize plugin tests
DevLab2425 Oct 19, 2023
7a4b43f
use response.text()
thescientist13 Nov 7, 2023
1789474
refactor init spec to fetch
thescientist13 Nov 7, 2023
1b237bc
all specs refactored to use fetch
thescientist13 Nov 7, 2023
4de60da
refactoring all specs
thescientist13 Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 10 additions & 26 deletions packages/cli/test/cases/develop.default.hud-disabled/develop.default.hud-disabled.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import fs from 'fs';
import { JSDOM } from 'jsdom';
import path from 'path';
import { getSetupFiles } from '../../../../../test/utils.js';
import request from 'request';
import { Runner } from 'gallinago';
import { runSmokeTest } from '../../../../../test/smoke-test.js';
import { fileURLToPath, URL } from 'url';
Expand Down Expand Up @@ -61,46 +60,31 @@ describe('Develop Greenwood With: ', function() {
describe('Develop command specific HUD HTML behaviors when disabled', function() {
let response = {};
let sourceHtml = '';
let dom;
let body;

before(async function() {
return new Promise((resolve, reject) => {
request.get({
url: `http://127.0.0.1:${port}`,
headers: {
accept: 'text/html'
}
}, (err, res, body) => {
if (err) {
reject();
}

response = res;

dom = new JSDOM(body);
sourceHtml = fs.readFileSync(fileURLToPath(new URL('./src/pages/index.html', import.meta.url)), 'utf-8');

resolve();
});
});
response = await fetch(`${hostname}:${port}`);
body = await response.clone().text();
sourceHtml = fs.readFileSync(fileURLToPath(new URL('./src/pages/index.html', import.meta.url)), 'utf-8');
});

it('should return the correct content type', function(done) {
expect(response.headers['content-type']).to.equal('text/html');
expect(response.headers.get('content-type')).to.equal('text/html');
done();
});

it('should return a 200', function(done) {
expect(response.statusCode).to.equal(200);
expect(response.status).to.equal(200);

done();
});

it('should contain the appropriate HUD output in the response', function(done) {
const body = dom.window.document.querySelectorAll('body')[0];
const dom = new JSDOM(body);
const bodyTag = dom.window.document.querySelectorAll('body')[0];

expect(body.textContent).not.to.contain('Malformed HTML detected, please check your closing tags or an HTML formatter');
expect(body.textContent.replace(/\\n/g, '').trim()).not.to.contain(sourceHtml.replace(/\\n/g, '').trim());
expect(bodyTag.textContent).not.to.contain('Malformed HTML detected, please check your closing tags or an HTML formatter');
expect(bodyTag.textContent.replace(/\\n/g, '').trim()).not.to.contain(sourceHtml.replace(/\\n/g, '').trim());

done();
});
Expand Down
36 changes: 10 additions & 26 deletions packages/cli/test/cases/develop.default.hud/develop.default.hud.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import fs from 'fs';
import { JSDOM } from 'jsdom';
import path from 'path';
import { getSetupFiles } from '../../../../../test/utils.js';
import request from 'request';
import { Runner } from 'gallinago';
import { runSmokeTest } from '../../../../../test/smoke-test.js';
import { fileURLToPath, URL } from 'url';
Expand Down Expand Up @@ -61,46 +60,31 @@ describe('Develop Greenwood With: ', function() {
describe('Develop command specific HUD HTML behaviors', function() {
let response = {};
let sourceHtml = '';
let dom;
let body;

before(async function() {
return new Promise((resolve, reject) => {
request.get({
url: `http://127.0.0.1:${port}`,
headers: {
accept: 'text/html'
}
}, (err, res, body) => {
if (err) {
reject();
}

response = res;

dom = new JSDOM(body);
sourceHtml = fs.readFileSync(fileURLToPath(new URL('./src/pages/index.html', import.meta.url)), 'utf-8');

resolve();
});
});
response = await fetch(`${hostname}:${port}`);
body = await response.clone().text();
sourceHtml = fs.readFileSync(fileURLToPath(new URL('./src/pages/index.html', import.meta.url)), 'utf-8');
});

it('should return the correct content type', function(done) {
expect(response.headers['content-type']).to.equal('text/html');
expect(response.headers.get('content-type')).to.equal('text/html');
done();
});

it('should return a 200', function(done) {
expect(response.statusCode).to.equal(200);
expect(response.status).to.equal(200);

done();
});

it('should contain the appropriate HUD output in the response', function(done) {
const body = dom.window.document.querySelectorAll('body')[0];
const dom = new JSDOM(body);
const bodyTag = dom.window.document.querySelectorAll('body')[0];

expect(body.textContent).to.contain('Malformed HTML detected, please check your closing tags or an HTML formatter');
expect(body.textContent.replace(/\\n/g, '').trim()).to.contain(sourceHtml.replace(/\\n/g, '').trim());
expect(bodyTag.textContent).to.contain('Malformed HTML detected, please check your closing tags or an HTML formatter');
expect(bodyTag.textContent.replace(/\\n/g, '').trim()).to.contain(sourceHtml.replace(/\\n/g, '').trim());

done();
});
Expand Down
Loading
Loading