Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test endpoint to fix suddenly failing test cases #1188

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Dec 5, 2023

Related Issue

In the wake of AnalogStudiosRI/www.analogstudios.net#97, forgot to come back and update this project to use the new v2 endpoints. Otherwise, all related test cases were failing, as observed in #1186 (comment).

Summary of Changes

  1. Update all Analog Studios endpoints from /api/artists -> /api/v2/artists for impacted test cases

@thescientist13 thescientist13 added the chore unit testing, maintenance, etc label Dec 5, 2023
@thescientist13 thescientist13 changed the title update test endpoint used in test cases update test endpoint to fix suddenly failing test cases Dec 5, 2023
@thescientist13 thescientist13 marked this pull request as ready for review December 5, 2023 13:38
@DevLab2425
Copy link
Contributor

DevLab2425 commented Dec 5, 2023

@thescientist13
Well, it seems I should have a bit more coffee before jumping into PRs. 🤦

Just realized that you created a PR and not an issue for me to tackle. So, here's my approach at resolving the endpoint. Happy to close though if that's best.

#1189

@thescientist13 thescientist13 merged commit f538f9a into master Dec 5, 2023
8 checks passed
@thescientist13 thescientist13 deleted the chore/fix-suddenly-failing-specs branch December 5, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore unit testing, maintenance, etc
Projects
Development

Successfully merging this pull request may close these issues.

2 participants