Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/issue 1241 prerendering formatting breaks bundle mapping optimization #1244

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Jun 7, 2024

Related Issue

resolves #1241

Summary of Changes

  1. refactor bundle mapping for <script>, <link> and <style> tags
  2. Validated through a test case

TODO

  1. finish script bundle mapping
  2. style bundle mapping refactoring
  3. link bundle mapping refactoring
  4. open up an issue tracking a more programmatic way to do this throughout greenwood - already existed, so added there
  5. can we solve this in modelResource? - issue is that modelResource happens before any prerendering, so won't be formatted in time 😞

@thescientist13 thescientist13 added bug Something isn't working CLI labels Jun 7, 2024
@thescientist13 thescientist13 marked this pull request as ready for review June 19, 2024 01:10
@thescientist13 thescientist13 force-pushed the bug/issue-1241-prerendering-formatting-breaks-bundle-mapping-optimzation branch from 4898beb to 0f1f6fc Compare June 26, 2024 01:22
@thescientist13 thescientist13 merged commit 4ce37fc into release/0.30.0 Jun 26, 2024
8 checks passed
@thescientist13 thescientist13 deleted the bug/issue-1241-prerendering-formatting-breaks-bundle-mapping-optimzation branch June 26, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prerendering breaks optimization configuration with multi-line formatted <script> / <style> / <link> tags
1 participant