escape special characters in mpa content #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
bug
thescientist13
changed the title
This was referenced Sep 29, 2021
thescientist13
deleted the
bug/issue-739-broken-mpa-pages-regex-lookahead-in-content
branch
This was referenced Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #739 as identified in #611
With this change in place against #611, I have been able to run the build 20 times and never saw the issue. As soon as I removed it, it started happening again, pretty much every other run, so feeling good about this!
Summary of Changes
.replacein MPA plugin ( same issue as inline optimization string replace calls that have a lookahead Regex inside a template literal ($) in the replacement string breaks users pages #656 )TODOs