Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #14

Merged
merged 3 commits into from
Jul 5, 2023
Merged

Update README.md #14

merged 3 commits into from
Jul 5, 2023

Conversation

D-Groenewegen
Copy link
Contributor

Deserves an update.

@D-Groenewegen
Copy link
Contributor Author

D-Groenewegen commented Jul 4, 2023 •
edited
Loading

Belated pull request. Expanded, updated and slighty rearranged sections.

@lutzhelm lutzhelm self-assigned this Jul 4, 2023
lutzhelm
lutzhelm requested changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@lutzhelm lutzhelm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting at this!
If you could just add the additional M2 indicators and remove the typo I would merge the PR.

I think we'll handle the PDF tutorial later. #12 is about that.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@D-Groenewegen
Update README.md
e02e7d8 
Some adjustments foll. suggestions by @lutzhelm
@lutzhelm lutzhelm merged commit c7fa32a into ProjectMirador:master Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbaiter jbaiter jbaiter left review comments

@lutzhelm lutzhelm lutzhelm approved these changes

Assignees

@lutzhelm lutzhelm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@D-Groenewegen @jbaiter @lutzhelm