Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seaport 1.1 #492

Draft
wants to merge 839 commits into
base: seaport-1.0
Choose a base branch
from
Draft

Seaport 1.1 #492

wants to merge 839 commits into from
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Jun 8, 2022

  1. code review

    @naps62
    naps62 committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    da9c12f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into 0xleastwood-update-contributors

    @0age
    0age committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    c60d5b6 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #452 from 0xleastwood/0xleastwood-update-contributors 

    Update CONTRIBUTORS.md
    @0age
    0age committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    256c420 View commit details
    Browse the repository at this point in the history

  4. Fix to reference Executor itemType

    @dmitriia
    dmitriia committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    2203c31 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #457 from axic/unused-params 

    Revert on dirty bits (unused item parameters)
    @0age
    0age committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    5eb8906 View commit details
    Browse the repository at this point in the history

  6. extend original work from @axic

    @0age
    0age committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    e096384 View commit details
    Browse the repository at this point in the history

  7. solve for stack issues with no viaIR

    @0age
    0age committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    28e9b91 View commit details
    Browse the repository at this point in the history

  8. basic test passes

    Aspyn Palatnick committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    17796eb View commit details
    Browse the repository at this point in the history

  9. Add a period

    @0age
    0age committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    a834fb3 View commit details
    Browse the repository at this point in the history

  10. tests pass

    Aspyn Palatnick committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    5f71832 View commit details
    Browse the repository at this point in the history

  11. update comment

    Aspyn Palatnick committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    5686211 View commit details
    Browse the repository at this point in the history

  12. clean up

    Aspyn Palatnick committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    d4f9c5b View commit details
    Browse the repository at this point in the history

  13. make ERC20 transfer on basic fulfillment agnostic

    @0age
    0age committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    55d0325 View commit details
    Browse the repository at this point in the history

  14. add scuffed length check

    Aspyn Palatnick committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    941bd53 View commit details
    Browse the repository at this point in the history

  15. update basic test

    Aspyn Palatnick committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    63461ca View commit details
    Browse the repository at this point in the history

  16. refactoring

    Aspyn Palatnick committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    d12f944 View commit details
    Browse the repository at this point in the history

  17. Added ENS name of JasperAlexander

    @JasperAlexander
    JasperAlexander committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    4c6dd5b View commit details
    Browse the repository at this point in the history

  18. Merge pull request #440 from mingwatch/mingwatch-gas-optimization-1 

    gas: add unchecked for ConduitController#updateChannel
    @0age
    0age committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    43467e5 View commit details
    Browse the repository at this point in the history

  19. clean up comments and formatting

    @0age
    0age committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    e8881cf View commit details
    Browse the repository at this point in the history

  20. Merge pull request #462 from JasperAlexander/main 

    Added ENS name of JasperAlexander
    @0age
    0age committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    fbd7b0d View commit details
    Browse the repository at this point in the history

  21. Merge pull request #453 from ProjectOpenSea/basic-order-type-readability 

    Assign basicOrderType to a variable rather than loading twice
    @0age
    0age committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    15cb65a View commit details
    Browse the repository at this point in the history

  22. run linter

    @0age
    0age committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    aa4060b View commit details
    Browse the repository at this point in the history

  23. clean up imports

    @0age
    0age committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    7d2b899 View commit details
    Browse the repository at this point in the history

  24. remove unused code

    Aspyn Palatnick committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    cc64d46 View commit details
    Browse the repository at this point in the history

  25. cleanup

    @0age
    0age committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    c7d391f View commit details
    Browse the repository at this point in the history

  26. add pragma to ConduitConstants

    @0age
    0age committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    15bd8a0 View commit details
    Browse the repository at this point in the history

  27. add test overflow denominator to 0

    @stephankmin
    stephankmin committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    5164ddd View commit details
    Browse the repository at this point in the history

  28. Merge branch 'main' into main

    @0age
    0age committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    fc93dcb View commit details
    Browse the repository at this point in the history

  29. remove unused code

    Aspyn Palatnick committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    38be6fc View commit details
    Browse the repository at this point in the history

  30. Merge pull request #448 from naps62/optimize-apply-fraction 

    Gas opt: skip `remaining` calculation when not necessary
    @0age
    0age committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    084c9d0 View commit details
    Browse the repository at this point in the history

  31. refactor assembly code

    Aspyn Palatnick committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    adc8067 View commit details
    Browse the repository at this point in the history

  32. Add selector constants

    @d1ll0n
    d1ll0n committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    cedddc7 View commit details
    Browse the repository at this point in the history

  33. add overflow numerator to 0, overflow numerator + denominator to 0

    @stephankmin
    stephankmin committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    5d3b2f7 View commit details
    Browse the repository at this point in the history

  34. Update tests 

    Add tests for InvalidNativeOfferItem and modify existing tests with an eth offer item
    @d1ll0n
    d1ll0n committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    7aea41d View commit details
    Browse the repository at this point in the history

  35. Add error InvalidNativeOfferItem

    @d1ll0n
    d1ll0n committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    3e12ddd View commit details
    Browse the repository at this point in the history

  36. Revert if offer item is ETH

    @d1ll0n
    d1ll0n committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    ff862bd View commit details
    Browse the repository at this point in the history

  37. Revert if offer item is ETH and not in match fn

    @d1ll0n
    d1ll0n committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    0cbe818 View commit details
    Browse the repository at this point in the history

  38. use consistent rounding logic in tests

    @emo-eth
    emo-eth committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    4d698a0 View commit details
    Browse the repository at this point in the history

  39. rm extra code

    Aspyn Palatnick committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    57c3bed View commit details
    Browse the repository at this point in the history

  40. fix tests

    @d1ll0n
    d1ll0n committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    507805d View commit details
    Browse the repository at this point in the history

  41. lint

    @d1ll0n
    d1ll0n committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    37fb95e View commit details
    Browse the repository at this point in the history

  42. clean up comments and natspec

    @0age
    0age committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    c86358d View commit details
    Browse the repository at this point in the history

  43. clean up reference as well

    @0age
    0age committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    cf9de88 View commit details
    Browse the repository at this point in the history

  44. add one last missing comment

    @0age
    0age committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    15f998f View commit details
    Browse the repository at this point in the history

  45. Merge pull request #463 from ProjectOpenSea/mingwatch-gas-optimization-1 

    Mingwatch gas optimization 1
    @0age
    0age committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    5d9eda7 View commit details
    Browse the repository at this point in the history

  46. test revert when numerator, denominator set to 0

    @stephankmin
    stephankmin committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    ba582b5 View commit details
    Browse the repository at this point in the history

  47. Remove redundant etherRemaining check for offer items

    @d1ll0n
    d1ll0n committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    915ab0a View commit details
    Browse the repository at this point in the history

  48. Merge pull request #425 from 0xsanson/main 

    Add contributor and some small stuff
    @0age
    0age committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    918d24c View commit details
    Browse the repository at this point in the history

  49. add blockdev as contributor

    @0xbok
    0xbok committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    e14b2ac View commit details
    Browse the repository at this point in the history

  50. refactoring

    Aspyn Palatnick committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    7be52d3 View commit details
    Browse the repository at this point in the history

  51. add ens

    @0xbok
    0xbok committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    b0c1880 View commit details
    Browse the repository at this point in the history

  52. fix merge conflict

    @stephankmin
    stephankmin committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    ca1de34 View commit details
    Browse the repository at this point in the history

  53. fix multiple typos and update CONTRIBUTORS.md

    @0xBaconPancakes
    0xBaconPancakes committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    729db31 View commit details
    Browse the repository at this point in the history

  54. Update reference contracts

    @d1ll0n
    d1ll0n committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    9257c85 View commit details
    Browse the repository at this point in the history

  55. Check if native offers were invalid after the loop

    @d1ll0n
    d1ll0n committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    6a7e070 View commit details
    Browse the repository at this point in the history

  56. uncomment lines

    @stephankmin
    stephankmin committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    a6ea4c7 View commit details
    Browse the repository at this point in the history

  57. lint

    @d1ll0n
    d1ll0n committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    803a888 View commit details
    Browse the repository at this point in the history

  58. Use nested scope to reduce stack depth

    @d1ll0n
    d1ll0n committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    6acfebc View commit details
    Browse the repository at this point in the history

  59. Use error buffer to get around stack depth compiler error

    @d1ll0n
    d1ll0n committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    d23c397 View commit details
    Browse the repository at this point in the history

  60. remove extra space

    @d1ll0n
    d1ll0n committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    d04a730 View commit details
    Browse the repository at this point in the history

  61. lint

    @d1ll0n
    d1ll0n committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    d63a18c View commit details
    Browse the repository at this point in the history

  62. Merge branch 'main' into blockdev

    @0age
    0age committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    725fab9 View commit details
    Browse the repository at this point in the history

  63. Merge pull request #466 from 0xbok/blockdev 

    add blockdev as contributor
    @0age
    0age committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    d0a6b1c View commit details
    Browse the repository at this point in the history

  64. clarify comment

    @d1ll0n
    d1ll0n committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    60e1071 View commit details
    Browse the repository at this point in the history

  65. Add comments for possible error buffer values

    @d1ll0n
    d1ll0n committed Jun 8, 2022
    2 Configuration menu
    Copy the full SHA
    18aabca View commit details
    Browse the repository at this point in the history

  66. use parameters.offerer directly

    @0age
    0age committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    a69b77f View commit details
    Browse the repository at this point in the history

  67. Update CONTRIBUTORS.md 

    For fixing a gas optimization in the C4 contest by asutorufo. By caching the length in the for-loops here:
https://github.com/ProjectOpenSea/seaport/blob/main/contracts/lib/OrderCombiner.sol#:~:text=uint256%20totalOfferItems%20%3D,totalOfferItems%3B%20%2B%2Bj)%20%7B
    @asutorufo
    asutorufo committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    08c1222 View commit details
    Browse the repository at this point in the history

  68. Update CONTRIBUTORS.md

    @asutorufo
    asutorufo committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    5192cfa View commit details
    Browse the repository at this point in the history

  69. Switched Executor's itemType to enumeration type

    @dmitriia
    dmitriia committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    a91f724 View commit details
    Browse the repository at this point in the history

  70. use scoped block for receivedItemType

    @0age
    0age committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    ca26ecd View commit details
    Browse the repository at this point in the history

  71. debug

    Aspyn Palatnick committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    3daa409 View commit details
    Browse the repository at this point in the history

  72. Merge pull request #468 from ProjectOpenSea/fraction-overflow-tests 

    Add forge tests for BadFraction values
    @0age
    0age committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    a69f02e View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2022

  1. one more stack too deep

    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    9e03376 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #465 from ProjectOpenSea/optimize-apply-fraction 

    Optimize apply fraction
    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    cbabacd View commit details
    Browse the repository at this point in the history

  3. Skip overflow check for eth offer item on fulfillAvailableOrders

    @d1ll0n
    d1ll0n committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    106904c View commit details
    Browse the repository at this point in the history

  4. Merge pull request #455 from shuklaayush/patch-1 

    Use local var instead of reading from storage in `ReferenceVerifiers`
    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    9b82d86 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into add_contributors

    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    9dc08ac View commit details
    Browse the repository at this point in the history

  6. Merge pull request #459 from dmitriia/add_contributors 

    Fix to reference Executor itemType
    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    564109c View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into fix-typos

    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    807c93d View commit details
    Browse the repository at this point in the history

  8. Merge pull request #467 from bokeh-eth/fix-typos 

    Fix multiple typos and update CONTRIBUTORS.md
    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    002c63f View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into restrict-eth-offer-items

    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    3ce8d0c View commit details
    Browse the repository at this point in the history

  10. progress

    Aspyn Palatnick committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    bef90cf View commit details
    Browse the repository at this point in the history

  11. Merge pull request #464 from ProjectOpenSea/restrict-eth-offer-items 

    Restrict eth offer items
    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    fd798b8 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'main' into signature-verification

    @Chomtana
    Chomtana committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    6ebf70e View commit details
    Browse the repository at this point in the history

  13. test 64 and 65-byte length 1271 signatures are handled correctly

    @emo-eth
    emo-eth committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    67a49f6 View commit details
    Browse the repository at this point in the history

  14. add fiveoutofnine.eth

    @fiveoutofnine
    fiveoutofnine committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    f21fd8e View commit details
    Browse the repository at this point in the history

  15. work around hardhat glitchiness

    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    6f5eb61 View commit details
    Browse the repository at this point in the history

  16. Merge pull request #472 from fiveoutofnine/main 

    add fiveoutofnine.eth
    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    739023f View commit details
    Browse the repository at this point in the history

  17. debugging

    Aspyn Palatnick committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    3da9316 View commit details
    Browse the repository at this point in the history

  18. Merge branch 'main' into main

    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    15f7d34 View commit details
    Browse the repository at this point in the history

  19. Merge pull request #470 from asutorufo/main 

    add contributor
    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    fe655d3 View commit details
    Browse the repository at this point in the history

  20. Merge pull request #451 from ProjectOpenSea/open-channel-modifier 

    [WIP] Open channel modifier
    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    c7c2fb2 View commit details
    Browse the repository at this point in the history

  21. working!

    Aspyn Palatnick committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    dc83233 View commit details
    Browse the repository at this point in the history

  22. test pass

    Aspyn Palatnick committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    3c3fda4 View commit details
    Browse the repository at this point in the history

  23. clean up

    Aspyn Palatnick committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    1ac5fb6 View commit details
    Browse the repository at this point in the history

  24. add fuzz tests

    Aspyn Palatnick committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    23d3d54 View commit details
    Browse the repository at this point in the history

  25. add some tests for coverage

    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    2789eff View commit details
    Browse the repository at this point in the history

  26. reference

    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    41c11fd View commit details
    Browse the repository at this point in the history

  27. push without building first: NOT EVEN ONCE

    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    4d03652 View commit details
    Browse the repository at this point in the history

  28. Merge pull request #460 from ProjectOpenSea/unused-params 

    protect against dirty values in unused item params
    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    fb5d1e4 View commit details
    Browse the repository at this point in the history

  29. Update CONTRIBUTORS.md

    @rfart
    rfart committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    de5ccd5 View commit details
    Browse the repository at this point in the history

  30. tests pass

    Aspyn Palatnick committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    401e68d View commit details
    Browse the repository at this point in the history

  31. clean up

    Aspyn Palatnick committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    b360491 View commit details
    Browse the repository at this point in the history

  32. ensure that basic order type is within range

    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    de470ce View commit details
    Browse the repository at this point in the history

  33. remove unused code

    Aspyn Palatnick committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    c26b6c1 View commit details
    Browse the repository at this point in the history

  34. rename and clean up comments

    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    9f5ce23 View commit details
    Browse the repository at this point in the history

  35. Merge pull request #473 from rfart/main 

    Update CONTRIBUTORS.md
    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    a110190 View commit details
    Browse the repository at this point in the history

  36. add comments

    Aspyn Palatnick committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    55caf9f View commit details
    Browse the repository at this point in the history

  37. improve naming

    Aspyn Palatnick committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    4e6d660 View commit details
    Browse the repository at this point in the history

  38. clean up

    Aspyn Palatnick committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    e3d777d View commit details
    Browse the repository at this point in the history

  39. add EIP1271_isValidSignature_selector

    @d1ll0n
    d1ll0n committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    0dd31db View commit details
    Browse the repository at this point in the history

  40. Try optimize signature

    @d1ll0n
    d1ll0n committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    7360797 View commit details
    Browse the repository at this point in the history

  41. check for 1 byte difference in sig length

    @d1ll0n
    d1ll0n committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    c64cbcf View commit details
    Browse the repository at this point in the history

  42. add comments

    Aspyn Palatnick committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    46960b2 View commit details
    Browse the repository at this point in the history

  43. Merge pull request #474 from ProjectOpenSea/mask-basic-order-type 

    ensure that basic order type is within range
    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    88f8a61 View commit details
    Browse the repository at this point in the history

  44. fix call to ecrecover precompile

    @d1ll0n
    d1ll0n committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    21d3fda View commit details
    Browse the repository at this point in the history

  45. run linter

    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    b72b6fd View commit details
    Browse the repository at this point in the history

  46. max 5k gas

    @d1ll0n
    d1ll0n committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    a9f0b4d View commit details
    Browse the repository at this point in the history

  47. expect BadContractSignature when contract exists

    @d1ll0n
    d1ll0n committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    0a27f22 View commit details
    Browse the repository at this point in the history

  48. Update CONTRIBUTORS.md

    @shuklaayush
    shuklaayush committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    88f544a View commit details
    Browse the repository at this point in the history

  49. Merge pull request #461 from ProjectOpenSea/aspyn/add-invalid-length-… 

    …order-tests

Add invalid length fulfill order tests
    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    1ee20da View commit details
    Browse the repository at this point in the history

  50. move modifier to top of contract

    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    485daa8 View commit details
    Browse the repository at this point in the history

  51. add ECDSA_MaxLength

    @d1ll0n
    d1ll0n committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    15b5f65 View commit details
    Browse the repository at this point in the history

  52. yulify

    @d1ll0n
    d1ll0n committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    da83e4e View commit details
    Browse the repository at this point in the history

  53. resolve merge conflicts

    @d1ll0n
    d1ll0n committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    8642409 View commit details
    Browse the repository at this point in the history

  54. lint

    @d1ll0n
    d1ll0n committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    6885bbd View commit details
    Browse the repository at this point in the history

  55. Merge pull request #477 from ProjectOpenSea/move-modifier 

    move modifier to top of contract
    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    f000b68 View commit details
    Browse the repository at this point in the history

  56. Merge pull request #476 from shuklaayush/patch-1 

    Add `shuklaayush` to contributors
    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    ff0f374 View commit details
    Browse the repository at this point in the history

  57. add constants for signature values

    @d1ll0n
    d1ll0n committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    063af49 View commit details
    Browse the repository at this point in the history

  58. Fix invalid v error and improve readability

    @d1ll0n
    d1ll0n committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    c1711de View commit details
    Browse the repository at this point in the history

  59. use existing 1271 wallet

    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    dd75af0 View commit details
    Browse the repository at this point in the history

  60. Merge branch 'main' into optimize-signature

    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    21e332c View commit details
    Browse the repository at this point in the history

  61. add TransferHelper contracts and tests

    @stephankmin
    stephankmin committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    02946fe View commit details
    Browse the repository at this point in the history

  62. change import file paths

    @stephankmin
    stephankmin committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    e73227d View commit details
    Browse the repository at this point in the history

  63. set fn to virtual

    @stephankmin
    stephankmin committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    d9fdd32 View commit details
    Browse the repository at this point in the history

  64. clean up signature verification

    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    ba7abf0 View commit details
    Browse the repository at this point in the history

  65. Merge branch 'optimize-signature' of https://github.com/ProjectOpenSe… 

    …a/seaport into optimize-signature
    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    bd05edb View commit details
    Browse the repository at this point in the history

  66. add one missing comment

    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    cb5e5b2 View commit details
    Browse the repository at this point in the history

  67. one more comment

    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    38f2055 View commit details
    Browse the repository at this point in the history

  68. throw invalid signature error where appropriate

    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    e9b5398 View commit details
    Browse the repository at this point in the history

  69. simplify code

    Aspyn Palatnick committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    4c12f11 View commit details
    Browse the repository at this point in the history

  70. move files into helper

    @stephankmin
    stephankmin committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    8d7211c View commit details
    Browse the repository at this point in the history

  71. file import

    @stephankmin
    stephankmin committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    f16aab8 View commit details
    Browse the repository at this point in the history

  72. add transferhelper to shim

    @stephankmin
    stephankmin committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    a953ddf View commit details
    Browse the repository at this point in the history

  73. add optional conduit key argument

    Aspyn Palatnick committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    aac540f View commit details
    Browse the repository at this point in the history

  74. Gas optimization, cache orderParameters.offer.length

    @eugenioclrc @ryanio
    eugenioclrc authored and ryanio committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    9295f34 View commit details
    Browse the repository at this point in the history

  75. Gas optimization, cache orderParameters.consideration.length

    @ryanio
    ryanio committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    229bc5a View commit details
    Browse the repository at this point in the history

  76. inspect raw revert reasons where necessary

    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    a8c3b6c View commit details
    Browse the repository at this point in the history

  77. get rid of empty debug

    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    db8ef16 View commit details
    Browse the repository at this point in the history

  78. inspect revert message directly on conduit test

    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    228d90a View commit details
    Browse the repository at this point in the history

  79. apply review comments

    @ryanio
    ryanio committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    cc21520 View commit details
    Browse the repository at this point in the history

  80. check that fuzzed conduit key doesn't equal conduitKeyOne

    @stephankmin
    stephankmin committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    9d8b841 View commit details
    Browse the repository at this point in the history

  81. throwOnCallFailures false in all hh configs

    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    4427f84 View commit details
    Browse the repository at this point in the history

  82. Merge pull request #482 from ProjectOpenSea/ryan/gas-optimization-cac… 

    …he-length

cache array lengths in OrderFulfiller for gas optimization
    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    529b770 View commit details
    Browse the repository at this point in the history

  83. Merge pull request #479 from ProjectOpenSea/aspyn/add-strict-invalid-… 

    …length-order-tests

Simplify code for base order test helper function
    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    6b68106 View commit details
    Browse the repository at this point in the history

  84. default to checking if signer is contract in reference to support 64&… 

    …65 byte length 1271 signatures
    @emo-eth
    emo-eth committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    5cc9de9 View commit details
    Browse the repository at this point in the history

  85. address line length limit

    @stephankmin
    stephankmin committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    6efbd2d View commit details
    Browse the repository at this point in the history

  86. bring signature reverts to parity with optimized

    @emo-eth
    emo-eth committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    f34f719 View commit details
    Browse the repository at this point in the history

  87. refactor helpers

    @emo-eth
    emo-eth committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    7cf0039 View commit details
    Browse the repository at this point in the history

  88. minor helper refactor

    @emo-eth
    emo-eth committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    d0b927e View commit details
    Browse the repository at this point in the history

  89. consistent capitalization; remove test start

    @emo-eth
    emo-eth committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    63726f4 View commit details
    Browse the repository at this point in the history

  90. update murky and forge solc version

    @emo-eth
    emo-eth committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    79ff9cd View commit details
    Browse the repository at this point in the history

  91. update optimizer runs

    @emo-eth
    emo-eth committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    e567fc6 View commit details
    Browse the repository at this point in the history

  92. final cleanup / optimization / safety pass

    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    4b187ba View commit details
    Browse the repository at this point in the history

  93. constants file too

    @0age
    0age committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    4674a21 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2022

  1. Merge pull request #475 from ProjectOpenSea/optimize-signature 

    Optimize signature verification
    @0age
    0age committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    4888cf6 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #484 from ProjectOpenSea/initial-refactor-test-hel… 

    …pers

Update Foundry to build with 0.8.14
    @0age
    0age committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    9e889bd View commit details
    Browse the repository at this point in the history

  3. update flowchart

    @ryanio
    ryanio committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    8eae46b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into transfer-helper

    @stephankmin
    stephankmin committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    d142907 View commit details
    Browse the repository at this point in the history

  5. bump compiler

    @stephankmin
    stephankmin committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    ed5bad9 View commit details
    Browse the repository at this point in the history

  6. remove padding from custom revert reasons

    @0age
    0age committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    637f32a View commit details
    Browse the repository at this point in the history

  7. update forge tests that somehow slipped through the cracks

    @0age
    0age committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    9ad6e1e View commit details
    Browse the repository at this point in the history

  8. Merge pull request #487 from ProjectOpenSea/fix-forge 

    update forge tests that somehow slipped through the cracks
    @0age
    0age committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    ecfa857 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into ryan/update-flowchart

    @0age
    0age committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    5d9aa4c View commit details
    Browse the repository at this point in the history

  10. remove minting logic from BaseOrderTest

    @stephankmin
    stephankmin committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    2a4ff55 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into transfer-helper

    @stephankmin
    stephankmin committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    ea62079 View commit details
    Browse the repository at this point in the history

  12. set fn virtual

    @stephankmin
    stephankmin committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    13a60fb View commit details
    Browse the repository at this point in the history

  13. override

    @stephankmin
    stephankmin committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    9b8201b View commit details
    Browse the repository at this point in the history

  14. Merge pull request #486 from ProjectOpenSea/ryan/update-flowchart 

    update flowchart
    @0age
    0age committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    779a429 View commit details
    Browse the repository at this point in the history

  15. Merge pull request #480 from ProjectOpenSea/transfer-helper 

    Add transfer helper
    @0age
    0age committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    0a8e82c View commit details
    Browse the repository at this point in the history

  16. ⚡️ AmountDeriver: optimize roundUp

    @transmissions11
    transmissions11 committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    d3ba3c0 View commit details
    Browse the repository at this point in the history

  17. 📝 Comment fix

    @transmissions11
    transmissions11 committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    1f77bbb View commit details
    Browse the repository at this point in the history

  18. ♻️ Lint

    @transmissions11
    transmissions11 committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    a671587 View commit details
    Browse the repository at this point in the history

  19. Update .prettierignore

    @transmissions11
    transmissions11 committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    407765d View commit details
    Browse the repository at this point in the history

  20. ♻️ Fix

    @transmissions11
    transmissions11 committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    8a08c8c View commit details
    Browse the repository at this point in the history

  21. 🎨 Prettier ignore

    @transmissions11
    transmissions11 committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    06721c1 View commit details
    Browse the repository at this point in the history

  22. ♻️ Revert prettier ignore

    @transmissions11
    transmissions11 committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    41ccf87 View commit details
    Browse the repository at this point in the history

  23. ✅ Fix test

    @transmissions11
    transmissions11 committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    a6af4f2 View commit details
    Browse the repository at this point in the history

  24. ✅ Fix test again

    @transmissions11
    transmissions11 committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    f3be430 View commit details
    Browse the repository at this point in the history

  25. Update ReferenceAmountDeriver.sol

    @transmissions11
    transmissions11 committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    34e7e98 View commit details
    Browse the repository at this point in the history

  26. small cleanup pass

    @0age
    0age committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    9ff321e View commit details
    Browse the repository at this point in the history

  27. Merge pull request #489 from ProjectOpenSea/ceil-opti 

    ⚡️ AmountDeriver: optimize roundUp
    @0age
    0age committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    c572a7f View commit details
    Browse the repository at this point in the history

  28. bump up to 19066 runs

    @0age
    0age committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    b093e7f View commit details
    Browse the repository at this point in the history

  29. Merge pull request #493 from ProjectOpenSea/bump-up-optimization-runs 

    bump up to 19066 runs
    @0age
    0age committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    d61ce29 View commit details
    Browse the repository at this point in the history

  30. fix typo in comment

    @leonardoalt
    leonardoalt committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    8f4b03c View commit details
    Browse the repository at this point in the history

  31. Test for clean name

    @hrkrshnn
    hrkrshnn committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    6dae733 View commit details
    Browse the repository at this point in the history

  32. Fixed a typo

    @hrkrshnn
    hrkrshnn committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    f7e7d87 View commit details
    Browse the repository at this point in the history

  33. Merge pull request #495 from hrkrshnn/clean-name-test 

    Clean name test
    @0age
    0age committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    33a4487 View commit details
    Browse the repository at this point in the history

  34. Merge pull request #494 from leonardoalt/fix_typo 

    fix typo in comment
    @0age
    0age committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    359a878 View commit details
    Browse the repository at this point in the history

  35. Update CriteriaResolution.sol 

     Based on https://github.com/Rari-Capital/solmate/blob/v7/src/utils/MerkleProof.sol
    @gpersoon
    gpersoon committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    88e74bb View commit details
    Browse the repository at this point in the history

  36. Update CriteriaResolution.sol 

    replaced `proof.length` with `mload(proof)`
    @gpersoon
    gpersoon committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    4837a1f View commit details
    Browse the repository at this point in the history

  37. update contributors.md

    @big-tech-sux
    big-tech-sux committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    7848a19 View commit details
    Browse the repository at this point in the history

  38. Merge pull request #496 from gpersoon/patch-2 

    Update CriteriaResolution.sol
    @0age
    0age committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    6fdd224 View commit details
    Browse the repository at this point in the history

  39. perform some comment clarification and formatting cleanup

    @0age
    0age committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    7d90fdc View commit details
    Browse the repository at this point in the history

  40. Merge pull request #497 from ProjectOpenSea/comment-cleanup 

    perform some comment clarification and formatting cleanup
    @0age
    0age committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    2dfbbde View commit details
    Browse the repository at this point in the history

  41. Update CONTRIBUTORS.md 

    Add Riley Holterhus to contributors list
    @rholterhus
    rholterhus committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    2855a69 View commit details
    Browse the repository at this point in the history

  42. Merge pull request #499 from ProjectOpenSea/rholterhus-patch-1 

    Update CONTRIBUTORS.md
    @0age
    0age committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    4523dcc View commit details
    Browse the repository at this point in the history

  43. Merge branch 'main' into patch-1

    @0age
    0age committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    8a08411 View commit details
    Browse the repository at this point in the history

  44. Merge pull request #498 from big-tech-sux/patch-1 

    update contributors.md
    @0age
    0age committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    3b93954 View commit details
    Browse the repository at this point in the history

  45. remove fixed gas on ecrecover precompile call

    @0age
    0age committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    a73c483 View commit details
    Browse the repository at this point in the history

  46. add test revert on nonzero unused params

    @stephankmin @emo-eth
    stephankmin authored and emo-eth committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    f4dd1e0 View commit details
    Browse the repository at this point in the history

  47. resolve invalidsigner

    @emo-eth
    emo-eth committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    e73ce0f View commit details
    Browse the repository at this point in the history

  48. progress on token/id tests

    @stephankmin @emo-eth
    stephankmin authored and emo-eth committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    ba5e510 View commit details
    Browse the repository at this point in the history

  49. move Invalid1155BatchTransferEncoding to TokenTransferrerErrors.sol

    @0age
    0age committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    c41f855 View commit details
    Browse the repository at this point in the history

  50. fix changes

    @emo-eth
    emo-eth committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    77eaf9f View commit details
    Browse the repository at this point in the history

  51. Merge pull request #500 from ProjectOpenSea/no-fixed-ecrecover-gas 

    remove fixed gas on ecrecover precompile call
    @0age
    0age committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    e04c6b8 View commit details
    Browse the repository at this point in the history

  52. Merge pull request #501 from ProjectOpenSea/move-error-interface-loca… 

    …tion

move Invalid1155BatchTransferEncoding to TokenTransferrerErrors.sol
    @0age
    0age committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    7b39986 View commit details
    Browse the repository at this point in the history

  53. fix unusedidentifier test

    @emo-eth
    emo-eth committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    d24dba7 View commit details
    Browse the repository at this point in the history

  54. update libs

    @emo-eth
    emo-eth committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    bcb935f View commit details
    Browse the repository at this point in the history

  55. add test identifier erc20

    @stephankmin
    stephankmin committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    8720ae3 View commit details
    Browse the repository at this point in the history

  56. add preapproved token

    @emo-eth
    emo-eth committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    58c3b99 View commit details
    Browse the repository at this point in the history

  57. add more tests

    @stephankmin
    stephankmin committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    6447373 View commit details
    Browse the repository at this point in the history

  58. add rest of consideration item tests

    @stephankmin
    stephankmin committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    954f5e7 View commit details
    Browse the repository at this point in the history

  59. include test for spend against null address with invalid signature; f… 

    …ix unused param in _performTestFulfillOrderRevertInvalidArrayLength
    @emo-eth
    emo-eth committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    ac35150 View commit details
    Browse the repository at this point in the history

  60. change wording

    @stephankmin
    stephankmin committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    7990bf9 View commit details
    Browse the repository at this point in the history

  61. add offer test

    @stephankmin
    stephankmin committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    e1073ab View commit details
    Browse the repository at this point in the history

  62. fix order type

    @stephankmin
    stephankmin committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    451a50d View commit details
    Browse the repository at this point in the history

  63. fix invalid msg value

    @stephankmin
    stephankmin committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    b913601 View commit details
    Browse the repository at this point in the history

  64. Merge branch 'main' into unused-parameters-tests

    @stephankmin
    stephankmin committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    de9b21c View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2022

  1. add erc20 offer test

    @stephankmin
    stephankmin committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    6818db9 View commit details
    Browse the repository at this point in the history

  2. implement nits from readthrough

    @0age
    0age committed Jun 11, 2022
    2 Configuration menu
    Copy the full SHA
    86e7ec6 View commit details
    Browse the repository at this point in the history

  3. keep FiveWords

    @0age
    0age committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    3a7f9e3 View commit details
    Browse the repository at this point in the history

  4. add erc20 offer test for fulfillOrder

    @stephankmin
    stephankmin committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    ff460b1 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #503 from ProjectOpenSea/readthrough-nits 

    implement nits from readthrough
    @0age
    0age committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    3a23794 View commit details
    Browse the repository at this point in the history

  6. progress on final test

    @stephankmin
    stephankmin committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    caa1d0d View commit details
    Browse the repository at this point in the history

  7. close the loop finally

    @stephankmin
    stephankmin committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    ad7cc31 View commit details
    Browse the repository at this point in the history

  8. Merge pull request #485 from ProjectOpenSea/unused-parameters-tests 

    Ensure revert on non-zero token / identifier (native) and identifier (erc20) in transferred item params
    @0age
    0age committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    1a65f0e View commit details
    Browse the repository at this point in the history

  9. test fulfills revert with native offer items

    @emo-eth
    emo-eth committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    2b284d5 View commit details
    Browse the repository at this point in the history

  10. rename test for clarity

    @emo-eth
    emo-eth committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    250dc70 View commit details
    Browse the repository at this point in the history

  11. Merge pull request #502 from ProjectOpenSea/test-null-spend 

    Add Foundry test for failures when spending pre-approved items from null address with invalid signature
    @0age
    0age committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    06bf918 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'main' into test-native-offer-fulfill-reverts

    @0age
    0age committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    2f6d38b View commit details
    Browse the repository at this point in the history

  13. run linter

    @0age
    0age committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    ebee871 View commit details
    Browse the repository at this point in the history

  14. Merge pull request #504 from ProjectOpenSea/test-native-offer-fulfill… 

    …-reverts

Test that "fulfill" methods revert on Orders with Native offer items
    @0age
    0age committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    57baf77 View commit details
    Browse the repository at this point in the history

  15. run one final comment pass over the token transferrer

    @0age
    0age committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    487841b View commit details
    Browse the repository at this point in the history

  16. Merge pull request #505 from ProjectOpenSea/token-transferrer-comment… 

    …-pass

run one final comment pass over the token transferrer
    @0age
    0age committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    71f9035 View commit details
    Browse the repository at this point in the history

  17. include 1.1 contributors list in Seaport natspec

    @0age
    0age committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    0b1adf3 View commit details
    Browse the repository at this point in the history

  18. Merge pull request #506 from ProjectOpenSea/contributors-natspec 

    include 1.1 contributors list in Seaport natspec
    @0age
    0age committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    b444a9b View commit details
    Browse the repository at this point in the history

  19. update deployment addresses

    @0age
    0age committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    a0c99d2 View commit details
    Browse the repository at this point in the history

  20. include Rinkeby #code in link

    @0age
    0age committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    fa8bee7 View commit details
    Browse the repository at this point in the history

  21. Merge pull request #508 from ProjectOpenSea/update-deployment-addresses 

    update deployment addresses
    @0age
    0age committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    821a049 View commit details
    Browse the repository at this point in the history