Skip to content

Commit

Permalink
relative paths to libs is a no go
Browse files Browse the repository at this point in the history
  • Loading branch information
djviau committed Sep 21, 2023
1 parent 3d5f612 commit d49b759
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion shipyardDocs/exampleNFTTutorial/CustomNFTFunctionality.md
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ TraitLabel memory myFirstDynamicTrait {(

Look at `TraitLabelLib.sol` to get a better sense of how to set those values up.

Then I just call `setTrait` with `bytes32(uint256(0x6d6174657269616c))` as the `traitKey` argument, `1` as the `tokenID` argument, and `bytes32(uint256(0x416c756d696e756d))`. The `_setTrait` function will store the value (`_traits[tokenId][traitKey] = value;`) and emit a `TraitUpdated` event, to put the world on notice that token ID 1 now has a new trait on it.
Then I just call `setTrait` with `bytes32(uint256(<my_trait_key>))` as the `traitKey` argument, `1` as the `tokenID` argument, and `bytes32(uint256(0x416c756d696e756d))`. The `_setTrait` function will store the value (`_traits[tokenId][traitKey] = value;`) and emit a `TraitUpdated` event, to put the world on notice that token ID 1 now has a new trait on it.

## Next up:

Expand Down
2 changes: 1 addition & 1 deletion shipyardDocs/exampleNFTTutorial/ERC721Concepts.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Feel free to skip this section if you've already read about ERC-721 or perused the code on your own.

There's nothing like going straight to the source: [https://eips.ethereum.org/EIPS/eip-721#specification](https://eips.ethereum.org/EIPS/eip-721#specification). The ERC-721 spec outlines the bare minimum interface and behavior that a contract needs to implement in order to be recognized and treated as an ERC-721 contract by the rest of the web 3 ecosystem (such as OpenSea, block explorers, etc.). There are only a half dozen operative "MUST"s in there, so we've got a lot of leeway. Eventually, we're going to deploy a snazzy, gas-optimized ERC721 with some bonus features. But for now, let's take a look at the stock version, [OpenZeppelin's example ERC721](lib/openzeppelin-contracts/contracts/token/ERC721/ERC721.sol)
There's nothing like going straight to the source: [https://eips.ethereum.org/EIPS/eip-721#specification](https://eips.ethereum.org/EIPS/eip-721#specification). The ERC-721 spec outlines the bare minimum interface and behavior that a contract needs to implement in order to be recognized and treated as an ERC-721 contract by the rest of the web 3 ecosystem (such as OpenSea, block explorers, etc.). There are only a half dozen operative "MUST"s in there, so we've got a lot of leeway. Eventually, we're going to deploy a snazzy, gas-optimized ERC721 with some bonus features. But for now, let's take a look at the stock version, [OpenZeppelin's example ERC721](https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC721/ERC721.sol)

TODO (blocked): update with links within the repo throughout.

Expand Down

0 comments on commit d49b759

Please sign in to comment.