Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMS revisions #89

Merged
merged 4 commits into from
Jan 11, 2025
Merged

AMS revisions #89

merged 4 commits into from
Jan 11, 2025

Conversation

kafitzgerald
Copy link
Collaborator

This is primarily editorial updates to the notebooks, but also swaps the BinderHub links back to the Pythia BinderHub following today's discussion and adds a JupyterLab MyST extension so that the admonitions render (this then required changing some image specification syntax in the notebooks).

I can also split this into multiple PRs if helpful or I think we can just leave things as is and workaround if that's more comfortable at this point too. We'll probably just want to provide a link for the hub we want and will have to live with a few typos.

Copy link

github-actions bot commented Jan 11, 2025

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 2e7eac2
✅ Deployment Preview URL: https://ProjectPythia.github.io/advanced-viz-cookbook/_preview/89

@kafitzgerald
Copy link
Collaborator Author

I did skim through all of the notebooks in the preview and they look good as well as the build.

@kafitzgerald kafitzgerald requested a review from jukent January 11, 2025 18:25
Copy link
Collaborator

@jukent jukent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh gosh thanks for finding all these typos and overall grammar corrections!

@jukent jukent merged commit f945ea6 into ProjectPythia:main Jan 11, 2025
2 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants