Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pyxdg as a dependency #4

Closed
wants to merge 2 commits into from
Closed

Add pyxdg as a dependency #4

wants to merge 2 commits into from

Conversation

proletarius101
Copy link

As it is referred in

python-proton-core/proton/utils/environment.py

Line 24 in 8ab4101

from xdg import BaseDirectory

@proletarius101 proletarius101 changed the title Add xdg as a dependency Add pyxdg as a dependency Oct 23, 2023
@proletarius101
fix: wrong package was introduced
05cf64c 
It should be pyxdg which contains BaseDirectory
@XavierProton
Copy link
Contributor

Hi !
Thanks for the contribution.
However, as you can see in the code, pyxdg is not strictly necessary (library has a fallback option) so better not making it required as it is not.
Can you rewrite your MR but using extras_require for pyxdg ?
Thanks

@XavierProton XavierProton deleted the branch ProtonVPN:master October 23, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@proletarius101 @XavierProton