-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Use the Consumer
pattern for code generation.
#2282
Open
d0cd
wants to merge
24
commits into
testnet3
Choose a base branch
from
refactor/codegen-uses-consumer
base: testnet3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d0cd
changed the title
[Refactor] Use the
[Refactor] Use the Feb 26, 2023
Consumer
trait for code generation.Consumer
pattern for code generation.
Codecov Report
@@ Coverage Diff @@
## testnet3 #2282 +/- ##
============================================
+ Coverage 77.94% 78.06% +0.12%
============================================
Files 150 148 -2
Lines 4571 4619 +48
Branches 4569 4617 +48
============================================
+ Hits 3563 3606 +43
- Misses 1008 1013 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR,
AssociatedConstants
from the ASTVisitor
,Reconstructor
, andConsumer
traits.Consumer
.